Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Updater] Fix typo in updater namespace #41

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[Updater] Fix typo in updater namespace #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Controller/EditOrderAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Setono\SyliusOrderEditPlugin\Controller;

use Setono\SyliusOrderEditPlugin\Exception\NewOrderWrongTotalException;
use Setono\SyliusOrderEditPlugin\Updated\OrderUpdaterInterface;
use Setono\SyliusOrderEditPlugin\Updater\OrderUpdaterInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
Expand All @@ -16,7 +16,7 @@

final class EditOrderAction
{
public function __construct(

Check failure on line 19 in src/Controller/EditOrderAction.php

View workflow job for this annotation

GitHub Actions / Backwards Compatibility Check 

The parameter $orderUpdater of Setono\SyliusOrderEditPlugin\Controller\EditOrderAction#__construct() changed from Setono\SyliusOrderEditPlugin\Updated\OrderUpdaterInterface to a non-contravariant Setono\SyliusOrderEditPlugin\Updater\OrderUpdaterInterface
private readonly OrderUpdaterInterface $orderUpdater,
private readonly UrlGeneratorInterface $router,
private readonly RequestStack $requestStack,
Expand Down
2 changes: 1 addition & 1 deletion src/Resources/config/services/controller.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
class="Setono\SyliusOrderEditPlugin\Controller\EditOrderAction"
public="true"
>
<argument type="service" id="setono_sylius_order_edit.updated.order_updater" />
<argument type="service" id="setono_sylius_order_edit.updater.order_updater" />
<argument type="service" id="router" />
<argument type="service" id="request_stack" />
</service>
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/config/services/order_processing.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@
</service>

<service
id="setono_sylius_order_edit.updated.order_updater"
class="Setono\SyliusOrderEditPlugin\Updated\OrderUpdater"
id="setono_sylius_order_edit.updater.order_updater"
class="Setono\SyliusOrderEditPlugin\Updater\OrderUpdater"
>
<argument type="service" id="setono_sylius_order_edit.preparer.order_preparer" />
<argument type="service" id="setono_sylius_order_edit.provider.updated_order_provider" />
Expand Down
2 changes: 1 addition & 1 deletion src/Updated/OrderUpdater.php → src/Updater/OrderUpdater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

declare(strict_types=1);

namespace Setono\SyliusOrderEditPlugin\Updated;
namespace Setono\SyliusOrderEditPlugin\Updater;

use Doctrine\ORM\EntityManagerInterface;
use Setono\SyliusOrderEditPlugin\Checker\PostUpdateChangesCheckerInterface;
Expand Down
2 changes: 1 addition & 1 deletion src/Updated/OrderUpdaterInterface.php → src/Updater/OrderUpdaterInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

declare(strict_types=1);

namespace Setono\SyliusOrderEditPlugin\Updated;
namespace Setono\SyliusOrderEditPlugin\Updater;

use Setono\SyliusOrderEditPlugin\Exception\NewOrderWrongTotalException;
use Symfony\Component\HttpFoundation\Request;
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Updater/OrderUpdaterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
use Setono\SyliusOrderEditPlugin\Preparer\OrderPreparerInterface;
use Setono\SyliusOrderEditPlugin\Processor\UpdatedOrderProcessorInterface;
use Setono\SyliusOrderEditPlugin\Provider\UpdatedOrderProviderInterface;
use Setono\SyliusOrderEditPlugin\Updated\OrderUpdater;
use Setono\SyliusOrderEditPlugin\Updater\OrderUpdater;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Messenger\Envelope;
use Symfony\Component\Messenger\MessageBusInterface;
Expand Down
Loading