Do not touch payments on edited orders #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
============================================
+ Coverage 73.51% 74.67% +1.16%
- Complexity 72 79 +7
============================================
Files 28 30 +2
Lines 370 387 +17
============================================
+ Hits 272 289 +17
Misses 98 98 ☔ View full report in Codecov by Sentry. |
Zales0123
force-pushed
the
do-not-touched-payment-on-edited-orders
branch
from
7b19388
to
8004c4f
Compare
loevgaard
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
There are two order payment processors in Sylius. The second one is handling payments on the completed orders and that's the one that resulted in a bug. Decorating it should fix the problem 🖖
The video shows that when editing the order that is not paid the payment amount would be changed as well, but when doing so on the paid order payments are not touched at all:
Nagranie.z.ekranu.2024-08-20.o.12.00.33.mov