Merge pull request #35 from Setono/fix-reordering

Fix possible throwing of exception when reordering menu items
Setono · Aug 15, 2024 · fc902aa · fc902aa
2 parents 1cd886f + 001d6f7
commit fc902aa
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/EventSubscriber/OrderShowMenuSubscriber.php b/src/EventSubscriber/OrderShowMenuSubscriber.php
@@ -11,6 +11,8 @@
 
 final class OrderShowMenuSubscriber implements EventSubscriberInterface
 {
+    private const MENU_ITEM_KEY = 'edit';
+
     public static function getSubscribedEvents(): array
     {
         return [OrderShowMenuBuilder::EVENT_NAME => 'addEditButton'];
@@ -27,7 +29,7 @@ public function addEditButton(OrderShowMenuBuilderEvent $event): void
 
         $menu
             ->addChild(
-                'edit',
+                self::MENU_ITEM_KEY,
                 [
                     'route' => 'sylius_admin_order_update',
                     'routeParameters' => ['id' => $order->getId()],
@@ -39,6 +41,12 @@ public function addEditButton(OrderShowMenuBuilderEvent $event): void
             ->setLabelAttribute('color', 'purple')
         ;
 
-        $menu->reorderChildren(['edit', 'order_history', 'cancel']);
+        $sort = [self::MENU_ITEM_KEY, 'order_history', 'cancel'];
+        $rest = array_diff(array_keys($menu->getChildren()), $sort);
+
+        try {
+            $event->getMenu()->reorderChildren(array_merge($sort, $rest));
+        } catch (\InvalidArgumentException) {
+        }
     }
 }