PR review fixes

Setono · Jun 27, 2024 · 69c63ac · 69c63ac
1 parent 76e13f3
commit 69c63ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/Resources/public/js/order-edit.js b/src/Resources/public/js/order-edit.js
@@ -1,6 +1,6 @@
 document.querySelectorAll('button.delete-order-item').forEach((button) => {
     button.addEventListener('click', (event) => {
-        var row = event.currentTarget.parentElement.parentElement;
+        var row = event.currentTarget.closest('tr');
         row.nextElementSibling.remove();
         row.remove();
     });
@@ -25,7 +25,7 @@ document.querySelector('button.add-order-item').addEventListener('click', (event
     var rows = orderItemTable.querySelectorAll('form[name="sylius_order"] tbody tr');
     var lastItemRowDeleteButton = rows[rows.length - 2].querySelector('button.delete-order-item');
     lastItemRowDeleteButton.addEventListener('click', (event) => {
-        var row = event.currentTarget.parentElement.parentElement;
+        var row = event.currentTarget.closest('tr');
         row.nextElementSibling.remove();
         row.remove();
     });

diff --git a/src/Setter/OrderDiscountAdjustmentSetter.php b/src/Setter/OrderDiscountAdjustmentSetter.php
@@ -21,8 +21,7 @@ public function __construct(
     public function set(OrderInterface $order, int $discount): void
     {
         $items = $order->getItems();
-        /** @var int $orderId */
-        $orderId = $order->getId();
+        $orderId = (int) $order->getId();
 
         $distributedPrices = $this->integerDistributor->distribute($discount, $items->count());