New control panels for world map and polity page maps

[edwardchalstrey1]

On 18th December 2024, I updated test website https://seshatdata.com/ to use this branch

Changes

For both the polity pages and the world map, there is now a simplified control panel on the left hand side. I've tested the pages on a range of different screen sizes, and I think it looks good now. Clicking the settings gear in the top left brings up the full set of controls. Reviewers, have a play around and comment if you notice any bugs I missed. If the maps pages aren’t loading correctly, please do a hard refresh on your browser (this is due to some JavaScript updates which might be ignored if you have a cached version – I will open a separate issue to avoid this in future).

New features/fixes include:

• On the world map, everything is "selected" by default, which looks nice when you play the animation, since the legend has everything (and is scrollable)
• Opening the settings, there is a new checkbox for "Hide unselected". The idea here, is if you unselect "Select all" and then click on a small subset of polities to highlight them, you can then hide everything else. Note: the map zoom is disabled whilst settings is open
• The dropdown that used to exist for "Full polities" vs "Polity components" is now removed

Hide unselected button example screenshot

Closed issues

Closes #145
Closes #200
Closes #163

TODO:

• 🐛 [BUG] - Map controls look bad on smaller screen sizes #200
• Make control panel expandable, closed by default
  • World map
  • Polity maps
• Background map should be a dropdown instead of a radio
  • World map
  • Polity maps
• Map should dynamically fill page
  • World map
  • Polity maps
• World map:
  • Fix play buttons
  • Settings button should bring up a panel in the middle of the screen that has to be closed
  • Ensure settings popup still appears for Globe
  • Always show full legend on Globe view, but move the popup that appears on click to the left
  • Don't show "hide unselected", "Select all" or "Clear selection" on globe view
  • Don't show the top left info box when the play button is active
  • Select all should be on by default
  • Make sure mini control panel play button is disabled if globe view selected
  • Ensure phone view still defaults to globe
  • Make sure polity popup and legend are not displayed when settings is open
  • Move the loading indicator to on top of map, not inside settings
  • Remove variables loading indicator and just keep the dropdown greyed out until ready
  • Remove "cliopatria-link" hiding considerations
  • Move select all and hide unselected to the legend
  • Make help box separate from the settings
  • Close help and settings whenever the slider moves
  • Ensure popup can never appear whilst settings or help open
  • Ensure legend cannot go off screen
  • Update the help to make sense in the context of the settings
  • Make the legend and popup invisible when empty
  • Keep the legend visible when settings/help open
  • Give the cross button a bit more padding
  • Make select all button greyed for cesium
  • Ensure variableLegend stays invisible when year is adjusted, but nothing selected
• Remove current borders loading indicator
  • World map
  • Polity maps
• Make the expanded control panel clearly scrollable so everything fits
  • World map
  • Polity maps
• Reduce the number of tickmarks when the screen is small
• Ensure the legend resizes to fit on screen
  • World map
  • Polity maps (maybe not needed)
• Add an i next to the play rate explaining it's the increment as well as the play rate
• Polity maps
  • Ensure component legend 2 doesn't appear behind help/settings
  • Reposition and resize help/settings
  • Implement a full screen button?
  • Ensure globe legend fits on screen always, when screen small
  • Tidy buttons
  • Ensure settings isn't needlessly big triggering scroll
  • Open bug issue for switching back from globe to anything else on polity maps making grey appear this is inconsistent and I cannot replicate
  • Only show legend if more than one item

[thobson88]

I like this, but the "Hide selected" and "Select all" checkboxes made more sense to me after I'd read your explanation here. So perhaps it's worth adding an info tooltip next to those checkboxes (similar to the one for the "Variable" drop-down menu).

[jbennettgit]

I like this as well, very clean. As a regular user I can see that the full/composite polities was a marginal option, especially since there are relatively few composites with different polities (and especially after coercing leaders and the like into polities). Still it would be nice for 'admins' or some such be able to review those constructs but maybe that needs to happen in another tool. Otherwise, bravo!