LibGfx+LibPDF: Add sample options to fill_path API (and other tidy ups) #25963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows selecting one of the implemented sample modes (e.g. Sample32xAA or Sample8xNoAA).
This updates LibPDF (and the aliased_fill test) to use the 2-bit NoAA sample for drawing triangles via the painter API. To make switching sample kinds easy down the line, the "Gfx::SampleAA" and "Gfx::SampleNoAA" aliases have been added for the default antialiased/aliased sample modes.
No need for this to be in the header (and could add to build times).
github-actions
bot
added
the
👀 pr-needs-review
nico
approved these changes
May 26, 2025
There was a problem hiding this comment.
Nice, thanks!
According to hyperfine 'Build/lagom/bin/pdf Tests/LibPDF/shade-gouraud-free.pdf --render-bench --render-repeats 50', a bit over 3% faster.
Before:
Benchmark 1: Build/lagom/bin/pdf Tests/LibPDF/shade-gouraud-free.pdf --render-bench --render-repeats 50
Time (mean ± σ): 620.8 ms ± 2.4 ms [User: 609.0 ms, System: 10.2 ms]
Range (min … max): 616.8 ms … 624.7 ms 10 runs
After:
Benchmark 1: Build/lagom/bin/pdf Tests/LibPDF/shade-gouraud-free.pdf --render-bench --render-repeats 50
Time (mean ± σ): 600.4 ms ± 3.6 ms [User: 589.1 ms, System: 9.9 ms]
Range (min … max): 595.2 ms … 607.1 ms 10 runs
One tiny nit:
| @@ -436,5 +436,6 @@ template class EdgeFlagPathRasterizer<Sample8xAA>; | |||
| template class EdgeFlagPathRasterizer<Sample16xAA>; | |||
| template class EdgeFlagPathRasterizer<Sample32xAA>; | |||
| template class EdgeFlagPathRasterizer<Sample8xNoAA>; | |||
| template class EdgeFlagPathRasterizer<Sample2xNoAA>; | |||
There was a problem hiding this comment.
nit: put above the 8xNoAA one for nicer sorting
| @@ -50,6 +50,21 @@ struct AA { | |||
| } | |||
| }; | |||
|
|
|||
| // 2-bit sample (mainly for use with NoAA). | |||
| @@ -247,10 +262,12 @@ using Sample8xAA = Detail::Sample8x<Detail::AA>; | |||
| using Sample16xAA = Detail::Sample16x<Detail::AA>; | |||
| using Sample32xAA = Detail::Sample32x<Detail::AA>; | |||
| using Sample8xNoAA = Detail::Sample8x<Detail::NoAA>; | |||
| using Sample2xNoAA = Detail::Sample2x<Detail::NoAA>; | |||
|
|
||
| extern template class EdgeFlagPathRasterizer<Sample8xAA>; | ||
| extern template class EdgeFlagPathRasterizer<Sample16xAA>; | ||
| extern template class EdgeFlagPathRasterizer<Sample32xAA>; | ||
| extern template class EdgeFlagPathRasterizer<Sample8xNoAA>; | ||
| extern template class EdgeFlagPathRasterizer<Sample2xNoAA>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.