who: Add who command #25943
Draft
who: Add who command #25943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
👀 pr-needs-review
nico
added
the
⏳ pr-waiting-for-author
AtkinsSJ
reviewed
May 21, 2025
github-actions
bot
removed
the
⏳ pr-waiting-for-author
ebanner
force-pushed
the
add-who-command
branch
3 times, most recently
from
1aca307 to
72d8ca1
Compare
kleinesfilmroellchen
suggested changes
May 22, 2025
| { | ||
| TRY(Core::System::pledge("stdio rpath")); | ||
| TRY(Core::System::unveil("/var/run/utmp", "r")); | ||
| TRY(Core::System::unveil("/etc", "r")); |
There was a problem hiding this comment.
It seems like the program only ever needs to read /etc/passwd here, please be more specific with your unveil then.
Comment on lines
+33
to
+36
| auto time = static_cast<time_t>(login_at); | ||
| auto* tm = localtime(&time); | ||
| char timebuf[32]; | ||
| strftime(timebuf, sizeof(timebuf), "%b %d %H:%M", tm); |
There was a problem hiding this comment.
Even though it’s a bad interface and I have a branch somewhere that fixes it, please rather use Core::LocalTime. We’re not C.
| json.as_object().for_each_member([&](auto& key, auto& value) { | ||
| auto const& obj = value.as_object(); | ||
| auto uid = obj.get_i32("uid"sv).value(); | ||
| auto* passwd = getpwuid(uid); |
There was a problem hiding this comment.
I am pretty sure Core::Account can do this with better error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.