Kernel: Allow acquiring the same LockRank multiple times #25932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we'd fail on acquiring the process level lockrank twice during jail propagation in `sys$fork`. Also while we are at it, make the VERIFYs neat little PANICs with good debug messages.
This delays it's destruction until the end of the function, which is necessary to avoid taking a mutex during said destruction, while under a spinlock.
This helps to enforce that we do not take Mutexes under SpinLocks. They still do not have a lasting effect on the LockRank while a Mutex is held, but only during acquisition and release.
github-actions
bot
added
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revival of #20619
Will likely conflict with #25931