Userland: Port some applications to the GML compiler #25859
Conversation
github-actions
bot
added
the
👀 pr-needs-review
RatcheT2497
force-pushed
the
various-gml-compilation-ports
branch
2 times, most recently
from
cd16e2b to
502a0a9
Compare
RatcheT2497
force-pushed
the
various-gml-compilation-ports
branch
from
502a0a9 to
c6c84e7
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
| { | ||
| auto background_settings_widget = TRY(adopt_nonnull_ref_or_enomem(new (nothrow) BackgroundSettingsWidget(background_settings_changed))); | ||
| auto background_settings_widget = TRY(adopt_nonnull_ref_or_enomem(new (nothrow) BackgroundSettingsWidget())); |
There was a problem hiding this comment.
Can you say more why this variable is redundant? Doesn't this undo #13456?
(if it truly is redundant: Now everyone passes false to the 3rd arg of ConnectionFromClient::set_system_theme, so we should remove that arg. But I'm guessing it's maybe needed.)
There was a problem hiding this comment.
I had a look into this... and this has been broken for a long time. It broke with ded5ba1, which landed a few weeks after #13456. It then further regressed with #17893, but it had already been broken for a long time by that point 😅 I believe restoring the intended behavior is a two-line fix though (#25915).
There was a problem hiding this comment.
Apologies for the late reply, didn't know a comment was left. MacDue explains it perfectly, so I won't repeat the explanation.
Sadly I've got no idea how to rebase now, as I don't believe there's any functionality in the GML compiler to pass data like this around between widgets. I'll take a look around for some alternative solutions when I have some time, but if one doesn't come up, should I just stash/remove the DisplaySettings portion of this PR?
Continuation of #25637 - couldn't get to it in time before it went stale and got closed. Addressed the redundant variable these PRs remove by splitting the change into its own commit.
Original description:
This PR contributes towards #20518
The ported applications are: ThemeEditor, DisplaySettings and ClockSettings.