Skip to content

Meta: Pass compiler's builtin includes to jakt too #25573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Meta: Pass compiler's builtin includes to jakt too #25573

merged 1 commit into from
May 28, 2025

Conversation

alimpfard
Copy link
Member

This is not an issue with clang, but when gcc is used as the c++ compiler, jakt can't know its builtin include paths; so come up with a nice and hacky cmake blob to fix the problem.

Warning: hacky!

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Dec 22, 2024
@alimpfard alimpfard requested a review from BertalanD as a code owner December 25, 2024 00:37
@alimpfard alimpfard force-pushed the jakt-includes-macos branch 4 times, most recently from fbc32fc to 5ab284f Compare December 27, 2024 11:02
@BuggieBot
Copy link
Member

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

ADKaster
ADKaster reviewed Dec 28, 2024
View reviewed changes
@stale Stale
Copy link

stale bot commented Jan 19, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Jan 19, 2025
@stale Stale
Copy link

stale bot commented Jan 26, 2025

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

@stale stale bot closed this Jan 26, 2025
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jan 26, 2025
@alimpfard alimpfard reopened this Feb 13, 2025
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Feb 13, 2025
nico
nico reviewed Feb 13, 2025
View reviewed changes
@stale stale bot removed the stale label Feb 13, 2025
nico
nico reviewed Feb 13, 2025
View reviewed changes
nico
nico reviewed Feb 13, 2025
View reviewed changes
@stale Stale
Copy link

stale bot commented Mar 7, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Mar 7, 2025
@stale Stale
Copy link

stale bot commented Mar 15, 2025

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

@stale stale bot closed this Mar 15, 2025
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Mar 15, 2025
@ADKaster ADKaster reopened this Apr 9, 2025
@stale stale bot removed the stale label Apr 9, 2025
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Apr 9, 2025
@ADKaster
Copy link
Member

ADKaster commented Apr 9, 2025

@alimpfard any further code change needed on this guy?

@alimpfard
Copy link
Member Author

I mean...it doesn't seem to be working quite right...

@stale Stale
Copy link

stale bot commented May 1, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label May 1, 2025
@stale Stale
Copy link

stale bot commented May 1, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale Stale
Copy link

stale bot commented May 8, 2025

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

@stale stale bot closed this May 8, 2025
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label May 8, 2025
@alimpfard alimpfard reopened this May 22, 2025
@alimpfard alimpfard force-pushed the jakt-includes-macos branch from c0363e6 to bdb3334 Compare May 22, 2025 18:18
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label May 22, 2025
@stale stale bot removed the stale label May 22, 2025
@alimpfard alimpfard force-pushed the jakt-includes-macos branch 4 times, most recently from 0d3270d to f28029f Compare May 23, 2025 18:03
@alimpfard
Meta: Pass compiler's builtin includes to jakt too
0253227 
This is not an issue with clang, but when gcc is used as the c++
compiler, jakt can't know its builtin include paths; so come up with a
nice and hacky cmake blob to fix the problem.
@alimpfard alimpfard force-pushed the jakt-includes-macos branch from f28029f to 0253227 Compare May 26, 2025 12:24
@alimpfard alimpfard merged commit d653eec into SerenityOS:master May 28, 2025
12 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nico nico nico left review comments

@ADKaster ADKaster ADKaster left review comments

@BertalanD BertalanD Awaiting requested review from BertalanD BertalanD is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alimpfard @BuggieBot @ADKaster @nico