Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick "Add support for Float16Array" #25434

Closed
wants to merge 3 commits into from
Closed

Conversation

nico
Copy link
Contributor

@nico nico commented Nov 18, 2024

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Nov 18, 2024
@nico nico marked this pull request as draft November 18, 2024 17:27
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Nov 18, 2024
(cherry picked from commit c1ec2ddb6399666fb84143388c8e3b1ad77a0281;
amended a bit for KERNEL ifdefs)
Implements TC39 stage three proposal for Float16Arrays:
https://tc39.es/proposal-float16array

(cherry picked from commit ea20545853ca3e8908353dcf96388f5bfe066ae5)
(cherry picked from commit 9ee7d4d90a0f029e154c796c51650096143446e4)
@nico
Copy link
Contributor Author

nico commented Nov 22, 2024

There's a proposal for f16 in wasm here: https://github.com/WebAssembly/half-precision/blob/main/proposals/half-precision/Overview.md

In the meantime, maybe we can just use i16 for f16. It'll break Float16Array in wasm js, but at least it'd work in the rest of the system.

Copy link

stale bot commented Dec 13, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Dec 13, 2024
Copy link

stale bot commented Dec 28, 2024

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

@stale stale bot closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants