Skip to content

Commit

Permalink
Fix docker version parsing
Browse files Browse the repository at this point in the history
Debian apt installs docker version with a postfix. E.g. "20.10.5+dfsg1"
Ignore this when checking for version.

Fixes #496
Fixes #447
  • Loading branch information
ukkopahis committed Feb 15, 2022
1 parent dc9df51 commit e0bfa12
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 1 deletion.
2 changes: 2 additions & 0 deletions install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ function do_docker_checks() {
DOCKER_VERSION_MAJOR=$(echo "$DOCKER_VERSION"| cut -d'.' -f 1)
DOCKER_VERSION_MINOR=$(echo "$DOCKER_VERSION"| cut -d'.' -f 2)
DOCKER_VERSION_BUILD=$(echo "$DOCKER_VERSION"| cut -d'.' -f 3)
DOCKER_VERSION_BUILD=$(echo "$DOCKER_VERSION_BUILD"| cut -f1 -d"-")
DOCKER_VERSION_BUILD=$(echo "$DOCKER_VERSION_BUILD"| cut -f1 -d"+")

if [ "$(minimum_version_check $REQ_DOCKER_VERSION $DOCKER_VERSION_MAJOR $DOCKER_VERSION_MINOR $DOCKER_VERSION_BUILD )" == "true" ]; then
[ -f .docker_outofdate ] && rm .docker_outofdate
Expand Down
1 change: 1 addition & 0 deletions menu.sh
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,7 @@ function do_docker_checks() {

DOCKER_VERSION_BUILD=$(echo "$DOCKER_VERSION"| cut -d'.' -f 3)
DOCKER_VERSION_BUILD=$(echo "$DOCKER_VERSION_BUILD"| cut -f1 -d"-")
DOCKER_VERSION_BUILD=$(echo "$DOCKER_VERSION_BUILD"| cut -f1 -d"+")

if [ "$(minimum_version_check $REQ_DOCKER_VERSION $DOCKER_VERSION_MAJOR $DOCKER_VERSION_MINOR $DOCKER_VERSION_BUILD )" == "true" ]; then
[ -f .docker_outofdate ] && rm .docker_outofdate
Expand Down
12 changes: 11 additions & 1 deletion scripts/deps/version_check.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
import re

def checkVersion(requiredVersion, currentVersion):
"""
>>> checkVersion('18.2.0', '20.10.11')
(True, '', [])
>>> checkVersion('18.2.0', '16.3.1')
(False, 'Version Check Fail', [False, False, True])
>>> checkVersion('18.2.0', '20.10.5+dfsg1')
(True, '', [])
"""
requiredSplit = requiredVersion.split('.')

if len(requiredSplit) < 2:
Expand All @@ -19,7 +29,7 @@ def checkVersion(requiredVersion, currentVersion):
try:
currentMajor = int(currentSplit[0])
currentMinor = int(currentSplit[1])
currentBuild = currentSplit[2].split("-")[0]
currentBuild = re.split(r'[+-]', currentSplit[2])[0]
currentBuild = int(currentBuild)
except:
return False, 'Invalid Current Version', currentVersion
Expand Down

0 comments on commit e0bfa12

Please sign in to comment.