Added "source_list_template" and "select_source" action features. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sennevds
reviewed
Jul 24, 2023
| @@ -201,7 +207,7 @@ async def _async_create_entities(hass, config): | |||
| current_sound_mode_template = device_config.get(CURRENT_SOUND_MODE_TEMPLATE) | |||
|
|
|||
| media_players.append( | |||
| MediaPlayerTemplate( | |||
| MediaPlayerTemplateDaxi( | |||
There was a problem hiding this comment.
Maybe rename back to MediaPlayerTemplate 🙂
Sennevds
reviewed
Jul 24, 2023
| @@ -247,7 +255,7 @@ async def _async_create_entities(hass, config): | |||
| return media_players | |||
|
|
|||
|
|
|||
| class MediaPlayerTemplate(TemplateEntity, MediaPlayerEntity): | |||
| class MediaPlayerTemplateDaxi(TemplateEntity, MediaPlayerEntity): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add the functionality to define the source_list via template and provides the select_source action to handle the source change event.
From my point of view, it will solve the Issue #33.
I have updated the readme.md file and simplified it to enable easy copy and paste to the configuration.yaml.
The documentation is done via comments and can be removed or kept by the user.
Kind regards,
CDaxi