fix options filling in select

SemanticMediaWiki · Sep 18, 2015 · 0a95764 · 0a95764
1 parent 87ea546
commit 0a95764
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -13,7 +13,7 @@ Original code from https://code.google.com/p/semanticformsselect/downloads/list
 
 ## Installation
 
-The recommended way to install Semantic Signup is by using [Composer][composer] with an entry in MediaWiki's `composer.json`.
+The recommended way to install Semantic Forms Select is by using [Composer][composer] with an entry in MediaWiki's `composer.json`.
 
 ```json
 {

diff --git a/SemanticFormsSelect.php b/SemanticFormsSelect.php
@@ -12,7 +12,7 @@
 		   'author' =>array( '[http://www.mediawiki.org/wiki/User:Jasonzhang Jasonzhang]', 'Toniher'),
 		   'url' => 'https://www.mediawiki.org/wiki/Extension:SemanticFormsSelect', 
 		   'description' => 'Generate a select field in Semantic Form which values are from query',
-		   'version'  => 1.2,
+		   'version'  => '1.2.1',
 	);
 
 	//$wgAjaxExportList[] = "QueryExecution";

diff --git a/scriptSelect.js b/scriptSelect.js
@@ -131,9 +131,8 @@ function SFSelect_setDependentValues (nameobj, fobj, values){
 			selectedValues=[selectedValues];
 		}
 
-		element.options.length=values.length+1;
-		//add an empty value so that end user can select none
-		element.options[0]=new Option("");
+		element.options.length=values.length;
+
 		var newselected=[];
 
 		if ( fobj.label ) {
-Original file line number
+Diff line change
@@ Expand Up @@
     ## Installation
-    The recommended way to install Semantic Signup is by using [Composer][composer] with an entry in MediaWiki's `composer.json`.
+    The recommended way to install Semantic Forms Select is by using [Composer][composer] with an entry in MediaWiki's `composer.json`.
     ```json
     {
@@ Expand Down @@