Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI for MW 1.43 #251

Merged
merged 10 commits into from
Jan 2, 2025
Merged

Add CI for MW 1.43 #251

merged 10 commits into from
Jan 2, 2025

Conversation

paladox
Copy link
Contributor

@paladox paladox commented Dec 31, 2024

No description provided.

@paladox
Copy link
Contributor Author

paladox commented Jan 1, 2025

I'm not sure how to get getUserGroups to return. We can't mock it because it's used inside the function without a way at supplying a param.

Any ideas @gesinn-it-gea / @gesinn-it-ilm ?

@gesinn-it-ilm
Copy link
Contributor

@paladox I will take a look.

@gesinn-it-ilm
UserGroupPropertyAnnotatorTest.php
3d116c2 
- update test
- use MediaWikiIntegrationTestCase instead of \PHPUnit\Framework\TestCase
- use MediaWikiIntegrationTestCase getTestUser() to create user with ID
@codecov Codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (12c89b9) to head (3d116c2).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #251      +/-   ##
============================================
+ Coverage     87.61%   87.62%   +0.01%     
  Complexity      370      370              
============================================
  Files            36       36              
  Lines          1090     1091       +1     
============================================
+ Hits            955      956       +1     
  Misses          135      135

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gesinn-it-ilm
Copy link
Contributor

@paladox now all looks good.
I have updated the UserGroupPropertyAnnotatorTest.php, you can take a look.

@paladox
Copy link
Contributor Author

paladox commented Jan 2, 2025

@paladox now all looks good. I have updated the UserGroupPropertyAnnotatorTest.php, you can take a look.

Oh, that’s awesome! Thanks! Looks good to me!

@gesinn-it-ilm
Copy link
Contributor

@paladox you are welcome. Then this PR is ready to be merged. :)

@JeroenDeDauw JeroenDeDauw merged commit cc90709 into master Jan 2, 2025
7 checks passed
@JeroenDeDauw JeroenDeDauw deleted the paladox-patch-1 branch January 2, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paladox @gesinn-it-ilm @JeroenDeDauw