-
Notifications
You must be signed in to change notification settings - Fork 0
Task/deploy application to minikube #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
targetPort: 8080 | ||
nodePort: 30080 | ||
name: api | ||
type: NodePort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you choose NodePort?
Is this suitable for this situation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ClusterIP more suitable for this situation or LoadBalancer? @ozgen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the clusterIp is recommended could you explain why @SelahattinSert
app: camera-onboarding | ||
spec: | ||
containers: | ||
- name: camera-onboarding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't you use resource limit?
containers: | ||
- name: camera-onboarding | ||
image: acrcameraonboarding.azurecr.io/cameraonboarding:20250228-e2d11b5 | ||
ports: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't you use readiness and liveliness probe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I use Spring Boot Actuator for this? @ozgen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yess you need to integrate this @SelahattinSert
|
||
```sh | ||
kubectl apply -k k8s/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you are using kustomize why dont you use kustomize command for deployment?
No description provided.