Skip to content

Task/deploy application to minikube #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SelahattinSert
Copy link
Owner

No description provided.

@SelahattinSert SelahattinSert self-assigned this Apr 11, 2025
@SelahattinSert SelahattinSert requested a review from ozgen April 11, 2025 00:05
targetPort: 8080
nodePort: 30080
name: api
type: NodePort
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you choose NodePort?
Is this suitable for this situation?

Copy link
Owner Author

@SelahattinSert SelahattinSert Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ClusterIP more suitable for this situation or LoadBalancer? @ozgen

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the clusterIp is recommended could you explain why @SelahattinSert

app: camera-onboarding
spec:
containers:
- name: camera-onboarding
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't you use resource limit?

containers:
- name: camera-onboarding
image: acrcameraonboarding.azurecr.io/cameraonboarding:20250228-e2d11b5
ports:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't you use readiness and liveliness probe?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I use Spring Boot Actuator for this? @ozgen

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yess you need to integrate this @SelahattinSert


```sh
kubectl apply -k k8s/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you are using kustomize why dont you use kustomize command for deployment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants