Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve logging #97

Merged
merged 2 commits into from
Aug 23, 2023
Merged

chore: improve logging #97

merged 2 commits into from
Aug 23, 2023

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Aug 23, 2023 •
edited
Loading

Contributor Comments

This is a minor chore that improves logging in generated projects when things are skipped

Pull Request Checklist

Thank you for submitting a contribution to cookiecutter-python!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • If you are adding a dependency, please explain how it was chosen.
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
  • Validate that documentation is accurate and aligned to any project updates or additions.

Don't forget our more detailed contribution guidelines
here.

@JonZeolla JonZeolla requested a review from seanctech as a code owner August 23, 2023 02:29
@JonZeolla JonZeolla enabled auto-merge (squash) August 23, 2023 02:32
@JonZeolla JonZeolla mentioned this pull request Aug 23, 2023
Merged
4 tasks
@JonZeolla JonZeolla requested a review from a team as a code owner August 23, 2023 13:54
@JonZeolla JonZeolla disabled auto-merge August 23, 2023 18:45
@JonZeolla JonZeolla added the blocked Unable to make progress label Aug 23, 2023
@JonZeolla
Copy link
Member Author

Pending SeisoLLC/goat#164

seanctech
seanctech approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@seanctech seanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JonZeolla JonZeolla merged commit febaea8 into main Aug 23, 2023
@JonZeolla JonZeolla deleted the improve-logging branch August 23, 2023 18:51
@JonZeolla JonZeolla removed the blocked Unable to make progress label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanctech seanctech seanctech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonZeolla @seanctech