fix: http-based generation #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
At some point in the past, likely in cb4d27f, we broke http support. This fixes that
Manual testing
Running
for template in git+ssh://[email protected]/seisollc/cookiecutter-python.git gh:seisollc/cookiecutter-python; do pipx run --system-site-packages cookiecutter --no-input ${template} --checkout fix-http-support --verbose; rm -rf TODO; doneshould succeed, which generates a project via HTTP and SSHPull Request Checklist
Thank you for submitting a contribution to cookiecutter-python!
In order to streamline the review of your contribution we ask that you review and comply with the below requirements:
Don't forget our more detailed contribution guidelines
here.