Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Flinn-Engdahl region names #135

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nackerley
Copy link
Contributor

The important thing here is that Senegal is spelled "Sengal", which is incorrect.

Additionally, since I could find no other French translation elsewhere (https://en.wikipedia.org/wiki/Flinn-Engdahl_regionalization only has translations to Spanish and German the same languages other than English supported by https://github.com/jsaul/flinnengdahl), I did my own translation to French. In the process, I found that the (inconsistent!) use of abbreviations really got in the way, so here I've also eliminated the abbreviations.

If there is a reason to keep the abbreviations, let me know and I'll initiate a pull request that only corrects the spelling of Senegal.

@cla-bot cla-bot bot added the cla-signed The CLA has been signed by all contributors label Aug 3, 2024
@gempa-jabe
Copy link
Contributor

I am must admit that I do not know why and how abbreviations made it into the names because Wikipedia does not use them. Maybe @jsaul can remember how this has happened. I am happy to merge your changes, thanks a lot.

@jsaul
Copy link
Contributor

jsaul commented Sep 4, 2024

The names were inherited from old Fortran codes and at some point turned into a more readable form as the original names where all upper case... The abbreviations were probably due to tight space constraints in the Fortran codes.

That said I appreciate the changes!

@jsaul
Copy link
Contributor

jsaul commented Sep 4, 2024

ObsPy actually maintains the original list of names here: https://github.com/obspy/obspy/blob/master/obspy/geodetics/data/names.asc?plain=1
"Papua New Guinea" is fully spelled out where space permits, and abbreviated as "P.N.G." and even "PNG.".
And "SENGAL" is there, too. ;)

@gempa-jabe
Copy link
Contributor

I personally would prefer Wikipedia as source for the names but that is just my opinion. Obspy is still using the very old version with IRIAN JAYA, so they might have taken that from the same source as we did 18 years ago ;)

In the end I do not want to offend anyone with old region names. Even putting only the FE region ID would be sufficient and anyone can grep her own translation.

@jsaul
Copy link
Contributor

jsaul commented Sep 4, 2024

@gempa-jabe Sorry for the misunderstanding, I was not proposing to go back to the original names, only referring to the old list for "historical reasons". 😃

And yes I would also strictly follow Wikipedia, but there we have the issue with https://en.wikipedia.org/wiki/Turkey

@gempa-jabe
Copy link
Contributor

Don't worry, I just wanted to add my opinion w.r.t. this PR and I understood your comment as how you intended it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The CLA has been signed by all contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants