Sheets language toggle #2227
Draft
Sheets language toggle #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g them to fit the expected old api response.
… to include an object for any language (he and en) rather than a string. The idea is to enable it to include other details and not only versionTitle.
…mbers and use it rather than placeSegmentNuncers.
…itle should be displayed.
…n there is more than one source.
…n the aources attribute is in the response.
…o components (rather than get it from cache objects).
…ng the translation VersionTitle.
…ned object in ssr processing.
this solves a bug when clicking on a search result in side bar - it should go to the specific segment and not to the beginning of the section. this is not how this issue should be handle, but this is what happening on prod.
…as languageFamilyName. this enables finding versions when we have only versionTitle without languageFamilyName (this happens in search results).
…s API accurately - with he/en meaning primary/translation and with the languageFamilyName param.
…with useEffect. control closing when clicking inside menu by adding a classname for preventing closing
…o dicta results..
…for segment level.
…HigherPriority in reduce call, for higher readability.
…utButton out of LayoutButtons.
…s for clicking on the open/close button and for click inside the menu contents.
…rsionTitle>, en: <versionTitle>}, while new ones have the form of new currVersions with versionTitle and languageFamilyName. this commit change way we check if versions are same to feet both old and new.
fix(acquire api-v3 text): encode versions uri for versionTitles that …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sheets will have the source /translation buttons, and layout buttons in bilingual state