Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trending Topics for Topic Landing Page #2211

Open
wants to merge 10 commits into
base: topic-landing
Choose a base branch
from

Conversation

yonadavGit
Copy link
Contributor

Description

This pull request introduces a new trending topics API and related frontend components. The backend has been updated to handle caching, filtering, and returning a configurable number of trending topics based on data from google analytics. The frontend now includes a new "Trending Topics" sidebar module to display the fetched topics.

Code Changes

Django Backend:
Added a trending_topics_api endpoint that returns a filtered list of topics.
Modified the get_trending_topics helper function to accept a variable n and handle topic filtering.
Added caching decorators to the get_trending_topics function for improved performance.
Frontend:
Introduced a TrendingTopics sidebar module to display trending topics dynamically.
Added logic in sefaria.js to fetch and cache trending topics from the API.
Updated the TopicLandingPage component to include the new TrendingTopics sidebar module.

Notes

Any additional notes go here

@yonadavGit yonadavGit requested a review from akiva10b January 5, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant