-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sc 27313/remove resources panel #2064
Open
stevekaplan123
wants to merge
20
commits into
sheets-viewer-final
Choose a base branch
from
feature/sc-27313/remove-resources-panel
base: sheets-viewer-final
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/sc 27313/remove resources panel #2064
stevekaplan123
wants to merge
20
commits into
sheets-viewer-final
from
feature/sc-27313/remove-resources-panel
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/Sefaria/Sefaria-Project into feature/sc-27313/remove-resources-panel
stevekaplan123
changed the base branch from
modularization-main
to
sheets-viewer-final
October 15, 2024 07:43
stevekaplan123
requested review from
edamboritz and
yitzhakc
and removed request for
akiva10b
November 6, 2024 10:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I removed the resources panel from the sheets viewer (and editor) as well as moving code that would no longer be used or relevant given that the resources panel is no longer part of the sheets viewer (and editor).
Code Changes
masterPanelMode === "Sheet"
cases have been removed. I removed several components no longer needed: AboutSheet, SheetToolsList, SheetNodeConnectionTools, MySheetsList, PublicSheetsList and AboutSheetButtons. Some of these components' code was copied over and is being re-used in components in other PRs for the Sheets Viewer. One particular component, ShareBox, has the exact same functionality that I need for the new Sheets Viewer, and so all I had to do was modify its prop MasterPanelSheetId to SheetId.highlightedNode
andhighlightedRefs
based on the sheet segment click. This allowed me to remove the function setSheetHighlight in ReaderApp and the functions openSheetConnectionsInPanel and closeSheetConnectionsInPanel in ReaderPanel as they are no longer called.