Improve error messaging and remove 500 errors #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edamboritz
reviewed
Jul 22, 2024
sefaria/system/decorators.py
Outdated
| @@ -42,7 +42,10 @@ def wrapper(*args, **kwargs): | |||
| except exps.InputError as e: | |||
| logger.warning("An exception occurred processing request for '{}' while running {}. Caught as JSON".format(args[0].path, func.__name__), exc_info=True) | |||
| request = args[0] | |||
| return jsonResponse({"error": str(e)}, callback=request.GET.get("callback", None)) | |||
There was a problem hiding this comment.
I think this should be in the view, its too specific for a generic decorator
edamboritz
reviewed
Oct 1, 2024
reader/views.py
Outdated
| try: | ||
| text = _get_text(oref, versionEn=versionEn, versionHe=versionHe, commentary=commentary, context=context, pad=pad, | ||
| alts=alts, wrapLinks=wrapLinks, layer_name=layer_name) | ||
| except Exception as e: |
There was a problem hiding this comment.
IIRC we discussed that we need to raise a proper error rather than do string comparison on the error message?
There was a problem hiding this comment.
Yes, I recall discussing that - and recall vaguely there being a reason we stuck with this. What would you recommend at this point?
api/views.py
Outdated
|
|
||
| try: | ||
| data = text_manager.get_versions_for_query() | ||
| except InputError as e: |
saengel
requested review from
edamboritz and
yitzhakc
and removed request for
nsantacruz
edamboritz
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve error messaging and remove 500 errors on the texts API (v1 and v2)
Code Changes
sefaria/model/text.py- Write more robust error message to be more helpful for our third party users.api/views.py- Properly catch error for Book Level Complex Texts, and report helpful error message.