Add second appendix to Mishnat Eretz Yisrael on Mishnah Megillah #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saengel
requested review from
edamboritz,
akiva10b,
stevekaplan123 and
YishaiGlasner
| new_node.validate() | ||
|
|
||
| # Add new node to correct position | ||
| attach_branch(new_node=new_node, parent_node=parent_node_mey, place=3) |
There was a problem hiding this comment.
place=3 will insert it before the fourth node, i.e. before chapter 3. i guess you want place=6
There was a problem hiding this comment.
Thanks for taking a look, @YishaiGlasner. Just replying here for the history even though we clarified by phone... assuming the node needs to be inserted at this level (vs a chapter level) this should be the correct approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script adds the second appendix to the Mishnat Eretz Yisrael commentary to Mishnah Megillah. Since the text is to be added manually, the script just creates the new node with the correct parameters, and inserts it into the correct location in the schema.