Dev #39
Merged
Dev #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(Markdown): markdown in admin editors was not being validated
…source-prompt-box-on-topic-editor fix(Source Editor): Prompts should be textareas not input elements
ES no longer requires this header to be set and it's problematic to set it to application/json because ES has a strange requirement that if Accept is set to "application/vnd.elasticsearch+json; compatible-with=8" (which is sent from our Python ES client) than Content-Type needs to be set to the same thing.
fix(TranslationBox): avoid sorting translations when there are none.
helm(search): dont set Content-Type header.
This ensures that both Dicta and Sefaria queries are using the same format of SearchTotal.
fix(search): move encapsulation of SearchTotal to search.js
fix(linker): fix order of parameters
… return true at certain API endpoints.
chore(alt tags): add alt tags for globe, bookmarks and notifications …
…-endpoints-improperly-set-params fix(api): patches a bug where setting a url param to false or 0 would…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.