forked from Sefaria/Sefaria-Project
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #35
Merged
Merged
Dev #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `other` Ref is a whole book, and `self` begins anywhere after first segment, `contains` is trivially false and we can avoid expensive code.
fix: Performance improvement of Ref.contains
…tch rest of source file
…to be editable through Strapi
… language is Hebrew
…nBlock, relocating functions (onVersionTitleClick, onSelectVersionClick, makeVersionLink) with updated names. Note: The following changes were necessitated by the above refactor and occurred as a result of moving functions to a new component: 1. Handle Hebrew translations in the same way as non-Hebrew. 2. Fix a bug related to single-section books where clicking on versionTitle would reload the page instead of opening the version in the sidebar. 3. Streamline the functions by removing unnecessary conditions based on VersionBlock.props for consistent behavior.
…r stripping notes and html), or wrap_all_entities (for adding html for ref links and topic links).
helm((feat): allocate more resources to mongo restore pod
…ich-promo Add a new redirect for tracking Munich promotional presentation
ci: update monorepo release rules
… in it that is more general.
…arted-video Hebrew button getting started video
fix: fully convert tref to URL form before looking it up in the legac…
test(search): fix failing search filter test
…egacy fix(legacy): replace input title with normalized title in case input …
ci: restrict pytest concurrency to test possible resource constraints
… so alt title will match exactly
…egacy fix(legacy ref): clean tref of underscores before replacing alt title…
Translations fix
fix(Search Result): markdown should be properly rendered
fix(search): remove newline that was auto-added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.