Skip to content

Commit

Permalink
Merge pull request #3 from SeeClickFix/gaurav/update-htmlsafe-import
Browse files Browse the repository at this point in the history
Update htmlSafe import
  • Loading branch information
ssawyer1024 authored Jun 8, 2023
2 parents ca41596 + c908d60 commit b16d2cd
Show file tree
Hide file tree
Showing 6 changed files with 44 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ jobs:
- ember-lts-3.24
- ember-lts-3.28
- ember-lts-4.4
- ember-lts-4.8
- ember-lts-4.12
- ember-release
- ember-beta
- ember-canary
Expand Down
2 changes: 1 addition & 1 deletion addon/helpers/linkify.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { typeOf } from '@ember/utils';
import { helper } from '@ember/component/helper';
import { htmlSafe } from '@ember/string';
import { htmlSafe } from '@ember/template';
import Ember from 'ember';
import { urlRegex, shortenUrl } from 'ember-linkify/utils/url-regex';

Expand Down
16 changes: 16 additions & 0 deletions config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,22 @@ module.exports = async function () {
},
},
},
{
name: 'ember-lts-4.8',
npm: {
devDependencies: {
'ember-source': '~4.8.0',
},
},
},
{
name: 'ember-lts-4.12',
npm: {
devDependencies: {
'ember-source': '~4.12.0',
},
},
},
{
name: 'ember-release',
npm: {
Expand Down
11 changes: 10 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ember-linkify",
"version": "5.0.0",
"version": "5.0.1",
"description": "Linkify urls in strings, safely",
"keywords": [
"linkify",
Expand Down Expand Up @@ -34,6 +34,7 @@
},
"devDependencies": {
"@ember/optional-features": "^2.0.0",
"@ember/string": "^3.1.1",
"@ember/test-helpers": "^2.6.0",
"@embroider/test-setup": "^0.48.1",
"@glimmer/component": "^1.0.4",
Expand Down Expand Up @@ -70,6 +71,9 @@
"qunit-dom": "^1.6.0",
"webpack": "^5.73.0"
},
"peerDependencies": {
"@ember/string": "^3.1.1"
},
"engines": {
"node": "12.* || 14.* || >= 16"
},
Expand Down
10 changes: 10 additions & 0 deletions tests/unit/helpers/linkify-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,3 +168,13 @@ test('it should properly handle fragments without leading slashes', function (as
'My link: <a href="http://some.website.com#fragment">http://some.website.com#fragment</a>'
);
});

test('it should properly handle newlines', function (assert) {
var result = linkify(['My link: http://some.website.com/\n\nNext line'])
.toString()
.trim();
assert.equal(
result,
'My link: <a href="http://some.website.com/">http://some.website.com/</a>\n\nNext line'
);
});

0 comments on commit b16d2cd

Please sign in to comment.