Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#1): catalogue and recommender integration #37
base: main
Are you sure you want to change the base?
feat(#1): catalogue and recommender integration #37
Changes from all commits
8a8836b
9c744b0
9c232c4
a091cee
6be4471
3c5ad9a
fb7f871
2e6ebdf
cdd9d5f
eb22d6e
0d210f0
9c0cbdc
62b090a
eaae483
d80d11e
4e411b7
7c8f6ce
fe84423
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not ideal in terms of security, but we have no choice if we want to be able to render any images stored in the offerings and participants.. if you have any ideas to make this more secure, let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing comes to mind as we are not the ones managing/storing the images...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This two commands are here to enable us to build the app without prefetching, therefore not requiring valid URLs for the catalogue or recommender. I am happy to remove that if you find this irrelevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I am more curious on why did you add it, as you add to the workflow the
env
? And ususally we don't need to build it as we work with it on dev mode (Just curious)This file was deleted.
This file was deleted.