Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): disable update button in tool arsenal #200

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

psyray
Copy link
Contributor

@psyray psyray commented Sep 12, 2024

  • Disabled the "Check Update" button in the Tool Arsenal section and replaced it with a placeholder indicating that the update feature is coming soon.

As we have moved to a poetry management for the python libs, permit update could break things.
When issue #143 will be solved we could restablish the update system.
Anyway we will frequently push new images with latest tool

- Disabled the "Check Update" button in the Tool Arsenal section and replaced it with a placeholder indicating that the update feature is coming soon.
Copy link
Contributor

sourcery-ai bot commented Sep 12, 2024

Reviewer's Guide by Sourcery

This pull request disables the "Check Update" button in the Tool Arsenal section of the scan engine settings page and replaces it with a placeholder button indicating that the update feature is coming soon.

File-Level Changes

Change Details Files
Replaced the functional 'Check Update' button with a disabled placeholder button
  • Removed the 'onclick' attribute that triggered the 'get_external_tool_latest_version' function
  • Changed the button text from 'Check Update' to 'Update disabled'
  • Added a small text '(Coming soon)' below the main button text
  • Kept the download icon and button styling consistent with the previous version
web/scanEngine/templates/scanEngine/settings/tool_arsenal.html

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@psyray psyray self-assigned this Sep 12, 2024
@psyray psyray requested a review from AnonymousWP September 12, 2024 00:40
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @psyray - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding more context to the PR description about why this change is necessary and if it's part of a larger feature rollout plan.
  • Instead of replacing the button with a disabled one, consider keeping the original button and adding a tooltip or a note nearby to indicate the upcoming feature. This maintains the UI structure for when the feature is ready.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@AnonymousWP AnonymousWP added the bug Something isn't working label Sep 12, 2024
@AnonymousWP AnonymousWP added enhancement New feature or request and removed bug Something isn't working labels Sep 12, 2024
@AnonymousWP AnonymousWP changed the title chore(ui): disable update button in tool arsenal feat(ui): disable update button in tool arsenal Sep 12, 2024
@AnonymousWP AnonymousWP merged commit 1a716a8 into release/2.1.0 Sep 12, 2024
5 checks passed
@AnonymousWP AnonymousWP deleted the disable-tool-update branch September 12, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants