-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: containerisation support #90
base: main
Are you sure you want to change the base?
feature: containerisation support #90
Conversation
Let's give it a shot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to validate that it does work both in Docker, and standalone on Windows with the .exe. I also verified that the data files are also set up correctly so that either way will work off of the same save.
I've added a couple of comments and requests that I think would make this a little more user friendly and hopefully remove some of the initial confusion around if docker was now the only way to run SoS.
I would like to see this get added, and it would not be a huge lift to maintain. It also lays the groundwork for eventually automating the building of the executable, and opens up more options people who want to run their own servers.
Sorry for the delay, I've been too much excited of playing the SoS with my friends :) Also to be noted, all of the time the shard has been hosted with the changes proposed, and we've encountered no troubles. |
Also, we've been playing on the very version of these -> https://github.com/devOwlish/sos_shard/actions |
@creiht Please review the changes when you'll have some spare time. Thanks! |
Shouldn't we integrate the instructions in the Manual.pdf to be consistent? |
The issue
When the server is started in a container or behind NAT, a client can't get past authorization screen. This happens because the game server IP is always a private one, which isn't accessible from outside.
To demonstrate the issue, let's take Orion Client logs ( some lines have been omitted ):
The solution
To solve the issue, we should be able to enforce
S_Address
being selected instead of any existing IP discovery, i.e.:which allows the server to be run in Docker locally. In case of running in a VPS/VDS or in a Kubernetes cluster, we can set it to
Misc
Also, I've included Dockerfile,
docker-compose.yaml
, and some changes to.gitignore
to make it easier to contribute.Please let me know if something needs to be changed!
Thanks!