Refactor into Unity Package #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support for loading repo as a package
add instructions to install through UPM
Use EditorState object map so we create a shared state per PathCreator instance so both OnSceneGUI and OnInspectorGUI operate on the same state All previous state variable fields are now properties accessing the EditorState's instance's fields so we do not have to change all usages of the previous fields Ensure we have an instance of EditorState on OnEnable
UPM compat
When in Unity's local pivot mode (toggled by pressing X) the anchors' handles are aligend to the path's curvature. Also, the controls' handles are pointing away from their respective anchors so it is much easier to define the tangents' lenghts.
Frames bounds of whole path if there is no selected handle, otherwise frames the selected handle
|
for future ref in case the repo owner ever comes back: this is a dupe PR of #90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this repo, might be worth looking at.
Adheres to official Unity standards.