Update to rmsceme 0.5.0 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use SceneTree API instead of blocks iterator - use text.TextDocument instead of scene_items.Text
- use SceneTree API instead of blocks iterator
- use SceneTree API instead of blocks iterator - use proper logger - mimic rm tree structure in the svg - add anchor position dictionary
- use text.TextDocument instead of scene_items.Text
Seb-sti1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To update from rmscene 0.2.0 to 0.3.0 the main modification is to use the SceneTree API instead of iterating the blocks. This was already done in ricklupton#5.
Then the biggest modification of rmscene from 0.3.0 to 0.5.0 is the removal of methods from
scene_items.Textobject. The intended replacement istext.TextDocument. This impacted themarkdown.print_textfunction and thesvg.draw_text.Rick Lupton also added some features in the PR 5, that i decided to keep in this pr:
I originally started this PR using the commits from ricklupton#5.