Skip to content

Commit

Permalink
Specify ID3 v2.3 tags when writing as Windows doesn't read ID3 v2.4. …
Browse files Browse the repository at this point in the history
…While it'd be nice to give the user the option to choose which they can use in the future it's rare that people "really" want v2.4 tags.
  • Loading branch information
SeanBannister committed Mar 4, 2014
1 parent d7fcc81 commit 9f57fda
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ function spawnWrite(src, dst, data) {
src, // input from src path
"-map",
"0",
"-id3v2_version",
"3",
"-codec",
"copy",
];
Expand Down

2 comments on commit 9f57fda

@parshap
Copy link

@parshap parshap commented on 9f57fda Mar 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Would you be interested in submitting a patch that makes v2.3 the default but adds an option to use v2.4?

@SeanBannister
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually started to write a patch but due to my use case requiring transcoding and tagging I've moved away from using this module and just running the ffmpeg command with child process.

Please sign in to comment.