siteForUrl: Bugfix - ignore query and search from input URL #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apepper
force-pushed
the
siteForUrl_ignores_hash_and_query
branch
from
0920fc3
to
9c02c87
Compare
dcsaszar
reviewed
Oct 18, 2024
Comment on lines
+38
to
+40
| const parsedUrl = new URL(fullUrl) | ||
| const url = `${parsedUrl.origin}${parsedUrl.pathname}` | ||
|
|
There was a problem hiding this comment.
- The easier fix is to include
#in the language detection regex. WDYT?
`^${getBaseAppUrl()}\\/(?<lang>[a-z]{2}(-[A-Z]{2})?)([?/#]|$)`,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise hash links like https://scrivito-portal-app.pages.dev/en#ecoline will not work. With this PR it works (see https://siteforurl-ignores-hash-and.scrivito-portal-app.pages.dev/en#ecoline).