Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make manifest files pass validation #135

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

StanIwan
Copy link
Contributor

Modifies manifest files to conform to validation rules that Screenly/cli#111 introduces.

@sergey-borovkov
Copy link

Let's add entrypoint: index.html everywhere

Copy link
Contributor

@nicomiguelino nicomiguelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nicomiguelino
Copy link
Contributor

nicomiguelino commented Sep 18, 2023

@sergey-borovkov, @StanIwan, @korvyashka
It seems that running screenly edge-app upload doesn't work on a newly-created Edge App.

Here's a sample console output:

2023-09-18T17:59:11.890Z DEBUG [reqwest::connect] starting new connection: https://api.screenlyapp.com/
2023-09-18T17:59:11.890Z DEBUG [hyper::client::connect::dns] resolving host="api.screenlyapp.com"
2023-09-18T17:59:11.892Z DEBUG [hyper::client::connect::http] connecting to 104.18.29.52:443
2023-09-18T17:59:11.914Z DEBUG [hyper::client::connect::http] connected to 104.18.29.52:443
2023-09-18T17:59:11.945Z DEBUG [hyper::proto::h1::io] flushed 549 bytes
2023-09-18T17:59:12.180Z DEBUG [hyper::proto::h1::io] parsed 10 headers
2023-09-18T17:59:12.180Z DEBUG [hyper::proto::h1::conn] incoming body is chunked encoding
2023-09-18T17:59:12.180Z DEBUG [hyper::proto::h1::decode] incoming chunked header: 0x42 (66 bytes)
2023-09-18T17:59:12.181Z DEBUG [hyper::proto::h1::conn] incoming body completed
2023-09-18T17:59:12.181Z DEBUG [hyper::client::pool] pooling idle connection for ("https", api.screenlyapp.com)
2023-09-18T17:59:12.182Z DEBUG [screenly::commands] Response: "{\"error\": \"Field 'entrypoint' doesn't exist.\", \"code\": \"PGRST118\"}"
Failed to upload edge app: unknown error: 400.

@sergey-borovkov
Copy link

@sergey-borovkov, @StanIwan, @korvyashka It seems that running screenly edge-app upload doesn't work on a newly-created Edge App.

Here's a sample console output:

2023-09-18T17:59:11.890Z DEBUG [reqwest::connect] starting new connection: https://api.screenlyapp.com/
2023-09-18T17:59:11.890Z DEBUG [hyper::client::connect::dns] resolving host="api.screenlyapp.com"
2023-09-18T17:59:11.892Z DEBUG [hyper::client::connect::http] connecting to 104.18.29.52:443
2023-09-18T17:59:11.914Z DEBUG [hyper::client::connect::http] connected to 104.18.29.52:443
2023-09-18T17:59:11.945Z DEBUG [hyper::proto::h1::io] flushed 549 bytes
2023-09-18T17:59:12.180Z DEBUG [hyper::proto::h1::io] parsed 10 headers
2023-09-18T17:59:12.180Z DEBUG [hyper::proto::h1::conn] incoming body is chunked encoding
2023-09-18T17:59:12.180Z DEBUG [hyper::proto::h1::decode] incoming chunked header: 0x42 (66 bytes)
2023-09-18T17:59:12.181Z DEBUG [hyper::proto::h1::conn] incoming body completed
2023-09-18T17:59:12.181Z DEBUG [hyper::client::pool] pooling idle connection for ("https", api.screenlyapp.com)
2023-09-18T17:59:12.182Z DEBUG [screenly::commands] Response: "{\"error\": \"Field 'entrypoint' doesn't exist.\", \"code\": \"PGRST118\"}"
Failed to upload edge app: unknown error: 400.

You need @rusko124 or @korvyashka to deploy those backend changes.

@StanIwan
Copy link
Contributor Author

I've seen that this PR https://github.com/Screenly/Screenly/pull/391 is now merged to master, so we can merge this.

@sergey-borovkov, please review :)

@StanIwan StanIwan merged commit cee200f into master Sep 19, 2023
2 checks passed
@StanIwan StanIwan deleted the make-manifests-pass-validation branch September 19, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants