Rewrite the Weather to an Edge App #105
Conversation
will not be enabled when `screenly.settings.disable_analytics` is set to `true`.
- Do a quick refactor as well to avoid long lines.
|
@nicomiguelino what are these things? Is this an encoding issue? |
edge-apps/weather/index.html
Outdated
| <script src="https://cdnjs.cloudflare.com/ajax/libs/moment.js/2.29.4/moment-with-locales.min.js" integrity="sha512-42PE0rd+wZ2hNXftlM78BSehIGzezNeQuzihiBCvUEB3CVxHvsShF86wBWwQORNxNINlBPuq7rG4WWhNiTVHFg==" crossorigin="anonymous" referrerpolicy="no-referrer"></script> | ||
|
|
||
| <script | ||
| src="https://cdnjs.cloudflare.com/ajax/libs/moment.js/2.29.4/moment-with-locales.min.js" |
There was a problem hiding this comment.
Let's ship moment as part of the edge app.
There was a problem hiding this comment.
All done (locally). Expect changes on succeeding commit/s.
edge-apps/weather/static/js/main.js
Outdated
| try { | ||
| const endpointUrl = `https://api.openweathermap.org/data/2.5/forecast` | ||
| const apiKey = screenly.settings.openweathermap_api_key | ||
| const queryParams = `lat=${lat}&lon=${lng}&units=metric&cnt=10&appid=${apiKey}` |
There was a problem hiding this comment.
Maybe it's easier to just pass the right unit here (matric is hard coded) than to do Fahrenheit conversion.
There was a problem hiding this comment.
I'll address this comment on another issue or pull request. I'll keep you posted.
There was a problem hiding this comment.
See #110 for details.
My bad, I haven't updated the screenshots. It's all good now. |
- Host `Moment.js` locally. - Have the indexed DB be cleared first before caching a new set of data. - Refactor how the query parameters are declared (for readability).
|
@vpetersson, I'd like to request a code review. Thanks. |
General
Checklist
edge-apps/weather/srcintoedge-apps/weather(the root directory) instead.gulpfile.js,.babelrc,load-metadata.js,load-screenly.js.index.html.main.jsget the OpenWeatherMap API key from the settings instead.Screenshots
In order to test the Weather app (rewritten as an Edge App), started a simple HTTP server by running
python3 -m http.server, which hosts the app at0.0.0.0:8000by default. I've also used a mockedscreenly.js, which I didn't commit in this PR.