#6: add indexing to BodyOfTheLastResponse. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perrygoy
commented
Feb 12, 2024
| @@ -23,11 +23,11 @@ def generate_send_method_class(method: str) -> Type[APIMethodAction]: | |||
| """ | |||
|
|
|||
| class SendMETHODRequest: | |||
| "Will be programmatically replaced." | |||
| """Will be programmatically replaced.""" | |||
There was a problem hiding this comment.
Oh yeah also i had this fix here for months. Haha.
There was a problem hiding this comment.
I figure when we add ruff to the project, all these would be updated anyway.
| @@ -53,6 +52,32 @@ def test_ask_for_body_of_the_last_response(self, APITester): | |||
|
|
|||
| assert BodyOfTheLastResponse().answered_by(APITester) == test_json | |||
|
|
|||
| def test_stores_index_path(self): | |||
| botlr = BodyOfTheLastResponse()["shuffled"]["off"][10]["mortal"]["coils"] | |||
|
Looks good! Only have one last suggestion: add a slice example to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
__getitem__handling forBodyOfTheLastResponse, which does two things:body_parts(sorry i couldn't help myself).self.This means further indexing will be kept track of in the
body_partslist. As the question is answered,BodyOfTheLastResponsechecks if it has anybody_parts, and will travel down the list for the user while answering the Question.One thing for discussion—should a
KeyErrororIndexErrorjust be let to bubble up, or should we catch that and tell the user what went wrong?