Release #67
Merged
Release #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #57 +sql/cased_usernames.sql: + Add user_name_cased column with the same type as user_name except it allows NULL. NULL values will be filled in on database update. includes/common/: db.php: * saveUser is now strictly assumed to take the case-sensitive username as input. Previously it didn't truly matter. * getUserBy* now return the cased username as well login.php: * Refactor the code that actually gets the user from the API and saves it to the DB into SOA2Login::api users.php: * getName now returns the CASED username by default, but can be told to return the lowercase one via a new parameter hooks.php: + Add the user_name_cased column via the SQL file + Run SOA2Login::api on every row with a NULL cased username
includes/common/hooks.php: * The proper way to do it is apparently addExtensionUpdate * I forgot that namespaces are a thing that affect things + Log the fetching of usernames
Include cased usernames in database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release needed to hotfix #65