Skip to content

Lama index integration #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Lama index integration #23

wants to merge 6 commits into from

Conversation

VinciGit00
Copy link
Contributor

No description provided.

Copy link

gitguardian bot commented Jan 2, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15022326 Triggered Generic High Entropy Secret b278943 cookbook/github-trending/.env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

github-actions bot commented Jan 2, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@VinciGit00 VinciGit00 requested a review from PeriniM January 2, 2025 10:07
lurenss

This comment was marked as duplicate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the files changed panel is not updated and they are not present in the codebase (https://github.com/ScrapeGraphAI/scrapegraph-sdk/tree/lama-index-integration/cookbook/company-info)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

Copy link
Member

@lurenss lurenss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An additonal thing:

notebook Cookbook in the cookbook folder are not the same as the one in the scrapegraph-py/cookbook, they need to share the same file both folders.

The one in the cookbook are right, just copy those in to scrapegraph-py/cookbook

@VinciGit00
Copy link
Contributor Author

Screenshot 2025-01-02 alle 15 38 48
a.py was removed originally and is not in the codebase

@VinciGit00
Copy link
Contributor Author

VinciGit00 commented Jan 2, 2025

An additonal thing:

notebook Cookbook in the cookbook folder are not the same as the one in the scrapegraph-py/cookbook, they need to share the same file both folders.

The one in the cookbook are right, just copy those in to scrapegraph-py/cookbook

interesting and we have to figure out the roadmap, other org like https://github.com/crewAIInc/crewAI splits the examples folder to a different repo https://github.com/crewAIInc/crewAI-examples from the principal codebase

@ScrapeGraphAI ScrapeGraphAI deleted a comment from lurenss Jan 2, 2025
@ScrapeGraphAI ScrapeGraphAI deleted a comment from lurenss Jan 2, 2025
@ScrapeGraphAI ScrapeGraphAI deleted a comment from lurenss Jan 2, 2025
@VinciGit00 VinciGit00 closed this Jan 2, 2025
@PeriniM PeriniM deleted the lama-index-integration branch February 1, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants