2.0.0 maverick #115
Open
2.0.0 maverick #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert repository pattern
Fix PSR-2 violations in control stuctures
Fix #93 | Fix the contact button on the profile image
Current coverage is 84.52% (diff: 81.84%)@@ master #115 diff @@
==========================================
Files 59 53 -6
Lines 759 892 +133
Methods 183 179 -4
Messages 0 0
Branches 0 0
==========================================
+ Hits 587 754 +167
+ Misses 172 138 -34
Partials 0 0
|
Psr violations
[DOCBLOCKS]: Copyright seeds
Nitpick-CI
reviewed
Dec 20, 2016
| $resource->setCursor($cursor); | ||
| $content = $fractal->createData($resource)->toJson(); | ||
| $status = Status::HTTP_OK; | ||
| } elseif((int) count($keys) === 0) { // There are no keys found. |
There was a problem hiding this comment.
Expected 1 space after ELSEIF keyword; 0 found
added 2 commits
December 22, 2016 23:18
Nitpick-CI
reviewed
Dec 28, 2016
| $xml->startDocument(); | ||
| $xml->startElement('activiteiten'); | ||
|
|
||
| foreach($query as $activity) { |
There was a problem hiding this comment.
Expected 1 space after FOREACH keyword; 0 found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.