[ZZZ] Add HoYoLab BattleChronicle page #1038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinaloe
changed the title
gongfuture
reviewed
Sep 12, 2024
|
Unfortunately, file encoding errors still exist. |
gongfuture
pushed a commit
to gongfuture/Starward
that referenced
this pull request
Sep 13, 2024
gongfuture
reviewed
Sep 13, 2024
There was a problem hiding this comment.
@Scighost 这个文件要是本地打开乱码要从GB 2312换成UTF-8。我这边看UTF-8打开是正常的
There was a problem hiding this comment.
@gongfuture Thanks for the follow up. You are correct, but I will put it back as it will be an unrelated change.
@Scighost Please re-check.
There was a problem hiding this comment.
Image_BattleChronicle.Source
There was a problem hiding this comment.
It appears that PR to other branches is required to add images... (And follow nuget package update)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add only the BattleChronicle page for ZZZ in HoYoLab.
Sorry, but I have only been able to check the global version, and I don't think it is behaving as intended in each Chinese version.