Completes the remainder of the code quality work #179
Conversation
ESadek-MO
force-pushed
the
code-quality-strands2
branch
from
07a3ab2 to
1acf396
Compare
![scitools-ci[bot]](https://avatars.githubusercontent.com/in/212324?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good, but I think you can get rid of these ignore entries from [tool.repo-review] now (GH212, PC170 and PC901):
(Sorry for the link, but GitHub won't let me apply comments to lines you have not modified in your PR in the review)
Also, is there a reason you didn't add the filterwarnings=["error"] to the pytest ini?
It's currently an sp-repo-review suggestion (PP309) that you have in your ignore list.
|
Evidently, that's why haha. I'll leave it out of this PR, and investigate later. |
Fair enough! It seems to be panicking over on the Warning, which is odd as the error level was set to "error"... |
ESadek-MO
dismissed
scitools-ci[bot]’s stale review
I have closed all the relevant issues; this pull request just further aligns to the templates, rather than changing them.
Resolves most of #155, save for filterwarnings (#177).
Closes #174.