Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to python 3.12 #271

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Move to python 3.12 #271

merged 8 commits into from
Nov 7, 2024

Conversation

HGWright
Copy link
Contributor

🚀 Pull Request

Description


.github/workflows/ci-wheels.yml Outdated Show resolved Hide resolved
requirements/py312.yml Outdated Show resolved Hide resolved
@HGWright
Copy link
Contributor Author

HGWright commented Sep 27, 2024

@trexfeathers Two things about this:

  1. Im a bit confused why this check is expected (could it be a handover of when that did run in this PR) but i still don't expect this.
  2. Had to do force push for conflicts, I think because this used to have a file that did not exist locally (py39 lockfile).

@trexfeathers
Copy link
Contributor

trexfeathers commented Nov 7, 2024

GitHub auto-merge must have 'required checks' in the branch protection rules. It looks like you (or maybe @bjlittle?) selected the following to be required (minus the CLA, which I selected):

This might mean we want to adjust our testing naming somehow so this doesn't become a problem every time we switch Python versions?

image

@trexfeathers trexfeathers merged commit a85ef50 into SciTools:main Nov 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants