-
Notifications
You must be signed in to change notification settings - Fork 292
Update Iris benchmarking to align with templating #6421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6421 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 90 90
Lines 23752 23752
Branches 4418 4418
=======================================
Hits 21331 21331
Misses 1672 1672
Partials 749 749 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
(draft while I wait for a benchmark report from this run - to prove that I haven't broken anything). |
⏱️ Performance Benchmark Report: 2703eabPerformance shifts
Full benchmark results
Generated by GHA run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small query, otherwise OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice work 👍
* Update Iris benchmarking to align with templating. * Revert licence header changes - align with test expectations.
* Update Iris benchmarking to align with templating. * Revert licence header changes - align with test expectations.
🚀 Pull Request
Description
Now we've create templates for benchmarking files (SciTools/.github#119), there are slight deviations between Iris and the templates. This PR removes those deviations.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: