Adds a warning for iris.coord_categorisation.add_season_membership that this is not saveable as a boolean coordinate.
#6305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6305 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 90 90
Lines 23752 23755 +3
Branches 4418 4418
=======================================
+ Hits 21331 21334 +3
Misses 1672 1672
Partials 749 749 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trexfeathers
requested changes
Apr 3, 2025
There was a problem hiding this comment.
Thanks @HGWright; I think we can increase this warning's value by widening its scope.
| "The 'season_membership' coordinate is a boolean and will not be" | ||
| "saveable to a NetCDF file. If you need to save the file you can" | ||
| "convert them to integers using coord.points = coord.points.astype(int)", | ||
| category=iris.warnings.IrisCfSaveWarning, |
There was a problem hiding this comment.
Suggested change
| category=iris.warnings.IrisCfSaveWarning, | |
| category=iris.warnings.IrisSaveWarning, |
This does not relate to CF itself, but to the NetCDF file format.
There was a problem hiding this comment.
Please can you add a What's New entry?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This addresses #5909, by raising a warning that since this adds a boolean, the result will not be saveable to a Netcdf file since it contains a boolean coordinate.
Note for reviewer:
I was not 100% sure on the type of error to raise either
iris.warnings.IrisSaveWarningoriris.warnings.IrisCfSaveWarningsince this a problem with Netcdf files.