[CI Bot] environment lockfiles auto-update #6215
Open
+15
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![scitools-ci[bot]](https://avatars.githubusercontent.com/in/212324?s=60&v=4){kind=small}
github-actions
bot
added
the
benchmark_this
⏱️ Performance Benchmark Report: 36c215dPerformance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: 36c215dPerformance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: 36c215dPerformance shiftsFull benchmark resultsGenerated by GHA run |
|
The most likely cause of the failures is SciTools/cf-units#184, though I thought I had tested Iris against my branch for that 😕 Most of the failing tests are using from iris.tests.stock import realistic_4d
cube = realistic_4d()
for pt in cube.coord('time').points:
print(pt)If we replace those points import numpy as np
new_points = np.linspace(347921, 347922, 7)[1:]
tcoord = cube.coord('time').copy(new_points)
print(tcoord)we get the expected Unfortunately that doesn't hold if we use float32 new_points = np.linspace(347921, 347922, 7, dtype=np.float32)[1:]
tcoord = cube.coord('time').copy(new_points)
print(tcoord) |
|
Questions:
If the answer to either of the above is "yes" then we probably should re-instate second rounding in |
⏱️ Performance Benchmark Report: e4c8a8bPerformance shiftsFull benchmark resultsGenerated by GHA run |
|
From @SciTools/peloton: we agree that the change to cf-units was correct and should be kept - it should align with cftime, and we expect anyone working directly with cf-units to be capable of handling changes of this nature. However: Iris users are an extra degree removed. Changes of this nature could cause significant behaviour change in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lockfiles updated to the latest resolvable environment.
If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.