Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_load_functions from 'load_factory_dims' PR#6168 #6191

Closed

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Oct 24, 2024

To confirm that these tests capture the legacy behaviours.

… that these tests capture the legacy behaviours.
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (b15e3e2) to head (94c75d2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6191      +/-   ##
==========================================
+ Coverage   89.82%   89.84%   +0.02%     
==========================================
  Files          88       88              
  Lines       23185    23211      +26     
  Branches     4314     4316       +2     
==========================================
+ Hits        20825    20854      +29     
+ Misses       1628     1626       -2     
+ Partials      732      731       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo
Copy link
Member Author

pp-mo commented Oct 24, 2024

Not to merge, just comforting that it passes.

@pp-mo pp-mo closed this Oct 24, 2024
@pp-mo pp-mo deleted the load_factory_dims__pretest_load_functions branch October 24, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant