Add format agent copy and equality methods #6119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6119 +/- ##
==========================================
+ Coverage 89.77% 89.82% +0.04%
==========================================
Files 88 88
Lines 23026 23150 +124
Branches 5036 5043 +7
==========================================
+ Hits 20672 20794 +122
- Misses 1623 1624 +1
- Partials 731 732 +1 ☔ View full report in Codecov by Sentry. |
…nto add-format-agent-copy * 'add-format-agent-copy' of github.com:jrackham-mo/iris: [pre-commit.ci] auto fixes from pre-commit.com hooks
ESadek-MO
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Thanks @jrackham-mo, code all looks good to me, just a minor change in the whastnew and should be good to go!
Co-authored-by: Elias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Closes #6108.
Adds a copy method to
FormatAgent, which creates a newFormatAgentfrom the format specs. Also adds an equality method which compares the format specs.The use case for this is to temporarily modify the
FORMAT_AGENTin a custom load, and then restore it so that we don't change standardiris.loadbehaviour outside of the custom load.