Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to iris.cube.Cube #6037

Merged
merged 17 commits into from
Sep 16, 2024
Merged

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jul 2, 2024

🚀 Pull Request

Description

Add type hints to iris.cube.Cube.

Closes #5567


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 95.68966% with 10 lines in your changes missing coverage. Please review.

Project coverage is 89.81%. Comparing base (2acfd92) to head (4670b18).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/iris/cube.py 96.27% 1 Missing and 5 partials ⚠️
lib/iris/analysis/__init__.py 75.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6037      +/-   ##
==========================================
- Coverage   89.82%   89.81%   -0.01%     
==========================================
  Files          88       88              
  Lines       23150    23174      +24     
  Branches     5043     5045       +2     
==========================================
+ Hits        20794    20814      +20     
+ Misses       1624     1623       -1     
- Partials      732      737       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela marked this pull request as ready for review July 11, 2024 09:18
@pp-mo pp-mo added this to the v3.10 milestone Jul 17, 2024
Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bouweandela, thanks so much for this, sorry for the delay of getting a review up.

This all looks great to me, happy for this to go in. Would you be happy to resolve the merge conflict, and then I can merge this!

@ESadek-MO ESadek-MO merged commit 9ee671c into SciTools:main Sep 16, 2024
21 checks passed
@bouweandela bouweandela deleted the cube-type-hints branch September 16, 2024 14:01
@bouweandela
Copy link
Member Author

Thanks for reviewing @ESadek-MO! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Type hint the public Cube API
3 participants