Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor area weighted regridding, improve performance #5543

Merged
merged 21 commits into from
Nov 20, 2023

Conversation

stephenworsley
Copy link
Contributor

🚀 Pull Request

Description

Implements #5365.

@stephenworsley stephenworsley added the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label Oct 19, 2023
@github-actions
Copy link
Contributor

Performance Benchmark Report: 86aa0d1

Performance shifts
| Change   | Before [97ee9acb]    | After [86aa0d19]    |   Ratio | Benchmark (Parameter)                                              |
|----------|----------------------|---------------------|---------|--------------------------------------------------------------------|
| -        | 520±6ms              | 139±1ms             |    0.27 | regridding.HorizontalChunkedRegridding.time_regrid_area_w          |
| -        | 610±3ms              | 147±1ms             |    0.24 | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid |
Full benchmark results

Benchmarks that have improved:

| Change   | Before [97ee9acb]    | After [86aa0d19]    |   Ratio | Benchmark (Parameter)                                              |
|----------|----------------------|---------------------|---------|--------------------------------------------------------------------|
| -        | 520±6ms              | 139±1ms             |    0.27 | regridding.HorizontalChunkedRegridding.time_regrid_area_w          |
| -        | 610±3ms              | 147±1ms             |    0.24 | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid |

Benchmarks that have stayed the same:

| Change   | Before [97ee9acb]    | After [86aa0d19]    | Ratio   | Benchmark (Parameter)                                                                                |
|----------|----------------------|---------------------|---------|------------------------------------------------------------------------------------------------------|
|          | n/a                  | n/a                 | n/a     | aux_factory.FactoryCommon.time_create                                                                |
|          | 5.77±0.05μs          | 5.70±0.1μs          | 0.99    | aux_factory.HybridHeightFactory.time_create                                                          |
|          | 6.38±0.04μs          | 6.30±0.06μs         | 0.99    | coords.AncillaryVariable.time_create                                                                 |
|          | 521±30ns             | 507±3ns             | 0.97    | coords.AuxCoord.time_bounds                                                                          |
|          | 11.7±0.08μs          | 11.8±0.1μs          | 1.01    | coords.AuxCoord.time_create                                                                          |
|          | 535±20ns             | 527±4ns             | 0.98    | coords.AuxCoord.time_points                                                                          |
|          | 327±10μs             | 328±20μs            | 1.00    | coords.AuxCoordLazy.time_bounds                                                                      |
|          | 15.7±0.5μs           | 15.9±0.6μs          | 1.01    | coords.AuxCoordLazy.time_create                                                                      |
|          | 324±10μs             | 325±20μs            | 1.00    | coords.AuxCoordLazy.time_points                                                                      |
|          | 6.89±0.1μs           | 6.90±0.1μs          | 1.00    | coords.CellMeasure.time_create                                                                       |
|          | 1.44±0.01μs          | 1.44±0.01μs         | 1.00    | coords.CellMethod.time_create                                                                        |
|          | n/a                  | n/a                 | n/a     | coords.CoordCommon.time_create                                                                       |
|          | 123±1μs              | 122±1μs             | 0.99    | coords.DimCoord.time_create                                                                          |
|          | 38.0±0.4μs           | 38.5±0.7μs          | 1.01    | coords.DimCoord.time_regular                                                                         |
|          | 799±4ms              | 800±6ms             | 1.00    | cube.Aggregation.time_aggregated_by                                                                  |
|          | 42.8±0.2μs           | 42.7±0.1μs          | 1.00    | cube.AncillaryVariable.time_add                                                                      |
|          | 8.86±0.08μs          | 8.86±0.1μs          | 1.00    | cube.AncillaryVariable.time_create                                                                   |
|          | 51.2±0.2μs           | 51.4±0.3μs          | 1.00    | cube.AuxCoord.time_add                                                                               |
|          | 7.29±0.04μs          | 7.33±0.08μs         | 1.01    | cube.AuxCoord.time_create                                                                            |
|          | 7.82±0.1μs           | 7.75±0.04μs         | 0.99    | cube.AuxCoord.time_return_coord_dims                                                                 |
|          | 5.89±0.05μs          | 5.81±0.05μs         | 0.99    | cube.AuxCoord.time_return_coords                                                                     |
|          | 45.3±0.5μs           | 45.3±0.4μs          | 1.00    | cube.AuxFactory.time_add                                                                             |
|          | 9.79±0.08μs          | 9.71±0.07μs         | 0.99    | cube.AuxFactory.time_create                                                                          |
|          | 42.7±0.2μs           | 42.8±0.1μs          | 1.00    | cube.CellMeasure.time_add                                                                            |
|          | 9.05±0.04μs          | 9.06±0.09μs         | 1.00    | cube.CellMeasure.time_create                                                                         |
|          | 36.4±0.2μs           | 36.3±0.1μs          | 1.00    | cube.CellMethod.time_add                                                                             |
|          | 4.98±0.06μs          | 4.96±0.06μs         | 1.00    | cube.CellMethod.time_create                                                                          |
|          | n/a                  | n/a                 | n/a     | cube.ComponentCommon.time_add                                                                        |
|          | n/a                  | n/a                 | n/a     | cube.ComponentCommon.time_create                                                                     |
|          | 194±0.1ms            | 195±0.3ms           | 1.00    | cube.Concatenate.time_concatenate                                                                    |
|          | 4.48±0.03μs          | 4.48±0.05μs         | 1.00    | cube.Cube.time_basic                                                                                 |
|          | 72.4±1ns             | 72.2±2ns            | 1.00    | cube.Cube.time_rename                                                                                |
|          | 168±0.5μs            | 168±1μs             | 1.00    | cube.Equality.time_equality                                                                          |
|          | 836±90ms             | 836±200ms           | 1.00    | cube.Merge.time_merge                                                                                |
|          | 32.5±1μs             | 33.0±1μs            | 1.01    | cube.MeshCoord.time_add(10000)                                                                       |
|          | 34.7±2μs             | 34.4±2μs            | 0.99    | cube.MeshCoord.time_add(1000000)                                                                     |
|          | 29.5±1μs             | 30.5±1μs            | 1.04    | cube.MeshCoord.time_add(6)                                                                           |
|          | 14.7±0.1μs           | 14.7±0.1μs          | 1.00    | cube.MeshCoord.time_create(10000)                                                                    |
|          | 14.6±0.1μs           | 14.7±0.1μs          | 1.00    | cube.MeshCoord.time_create(1000000)                                                                  |
|          | 14.3±0.09μs          | 14.3±0.1μs          | 1.00    | cube.MeshCoord.time_create(6)                                                                        |
|          | 69.2±4μs             | 69.9±4μs            | 1.01    | cube.MeshCoord.time_remove(10000)                                                                    |
|          | 76.7±5μs             | 74.8±4μs            | 0.98    | cube.MeshCoord.time_remove(1000000)                                                                  |
|          | 61.5±7μs             | 64.9±5μs            | 1.05    | cube.MeshCoord.time_remove(6)                                                                        |
|          | 2.92±0.3ms           | 2.93±0.3ms          | 1.00    | experimental.ugrid.Connectivity.time_create(1000000)                                                 |
|          | 1.95±0.01ms          | 1.97±0.01ms         | 1.01    | experimental.ugrid.Connectivity.time_create(6)                                                       |
|          | 842±20ns             | 823±7ns             | 0.98    | experimental.ugrid.Connectivity.time_indices(1000000)                                                |
|          | 841±20ns             | 820±7ns             | 0.97    | experimental.ugrid.Connectivity.time_indices(6)                                                      |
|          | 32.0±2ms             | 32.4±2ms            | 1.01    | experimental.ugrid.Connectivity.time_location_lengths(1000000)                                       |
|          | 2.96±0.03ms          | 2.96±0.02ms         | 1.00    | experimental.ugrid.Connectivity.time_location_lengths(6)                                             |
|          | 37.7±3ms             | 38.4±3ms            | 1.02    | experimental.ugrid.Connectivity.time_validate_indices(1000000)                                       |
|          | 4.45±0.01ms          | 4.47±0.01ms         | 1.00    | experimental.ugrid.Connectivity.time_validate_indices(6)                                             |
|          | 4.86±0.1ms           | 4.76±0.2ms          | 0.98    | experimental.ugrid.ConnectivityLazy.time_create(1000000)                                             |
|          | 3.39±0.03ms          | 3.40±0.03ms         | 1.00    | experimental.ugrid.ConnectivityLazy.time_create(6)                                                   |
|          | 311±5μs              | 311±5μs             | 1.00    | experimental.ugrid.ConnectivityLazy.time_indices(1000000)                                            |
|          | 308±4μs              | 308±4μs             | 1.00    | experimental.ugrid.ConnectivityLazy.time_indices(6)                                                  |
|          | 28.9±0.4ms           | 28.8±0.5ms          | 1.00    | experimental.ugrid.ConnectivityLazy.time_location_lengths(1000000)                                   |
|          | 3.26±0.03ms          | 3.29±0.03ms         | 1.01    | experimental.ugrid.ConnectivityLazy.time_location_lengths(6)                                         |
|          | 32.8±0.6ms           | 32.7±0.8ms          | 1.00    | experimental.ugrid.ConnectivityLazy.time_validate_indices(1000000)                                   |
|          | 4.77±0.05ms          | 4.80±0.05ms         | 1.01    | experimental.ugrid.ConnectivityLazy.time_validate_indices(6)                                         |
|          | 15.8±0.5μs           | 16.0±0.4μs          | 1.01    | experimental.ugrid.Mesh.time_add_connectivities(1000000)                                             |
|          | 301±2μs              | 304±2μs             | 1.01    | experimental.ugrid.Mesh.time_add_connectivities(6)                                                   |
|          | 6.11±0.1μs           | 6.18±0.2μs          | 1.01    | experimental.ugrid.Mesh.time_add_coords(1000000)                                                     |
|          | 5.99±0.05μs          | 6.00±0.04μs         | 1.00    | experimental.ugrid.Mesh.time_add_coords(6)                                                           |
|          | 6.30±0.1μs           | 6.34±0.08μs         | 1.01    | experimental.ugrid.Mesh.time_connectivities(1000000)                                                 |
|          | 6.33±0.04μs          | 6.29±0.06μs         | 0.99    | experimental.ugrid.Mesh.time_connectivities(6)                                                       |
|          | 7.80±0.1μs           | 7.82±0.1μs          | 1.00    | experimental.ugrid.Mesh.time_coords(1000000)                                                         |
|          | 7.57±0.04μs          | 7.48±0.04μs         | 0.99    | experimental.ugrid.Mesh.time_coords(6)                                                               |
|          | 54.8±2μs             | 54.0±0.8μs          | 0.98    | experimental.ugrid.Mesh.time_create(1000000)                                                         |
|          | 372±2μs              | 372±2μs             | 1.00    | experimental.ugrid.Mesh.time_create(6)                                                               |
|          | 124±3ms              | 123±3ms             | 0.99    | experimental.ugrid.Mesh.time_eq(1000000)                                                             |
|          | 332±3μs              | 334±1μs             | 1.00    | experimental.ugrid.Mesh.time_eq(6)                                                                   |
|          | 6.28±0.1μs           | 6.19±0.2μs          | 0.99    | experimental.ugrid.Mesh.time_remove_connectivities(1000000)                                          |
|          | 6.20±0.06μs          | 6.08±0.05μs         | 0.98    | experimental.ugrid.Mesh.time_remove_connectivities(6)                                                |
|          | 9.36±0.1μs           | 9.42±0.2μs          | 1.01    | experimental.ugrid.Mesh.time_remove_coords(1000000)                                                  |
|          | 9.30±0.2μs           | 9.28±0.06μs         | 1.00    | experimental.ugrid.Mesh.time_remove_coords(6)                                                        |
|          | 15.1±0.2μs           | 15.2±0.1μs          | 1.00    | experimental.ugrid.MeshCoord.time_bounds(10000)                                                      |
|          | 261±4ms              | 259±2ms             | 0.99    | experimental.ugrid.MeshCoord.time_bounds(1000000)                                                    |
|          | 7.05±0.07μs          | 6.96±0.05μs         | 0.99    | experimental.ugrid.MeshCoord.time_bounds(6)                                                          |
|          | 4.43±0.03ms          | 4.44±0.01ms         | 1.00    | experimental.ugrid.MeshCoord.time_create(10000)                                                      |
|          | 4.47±0.02ms          | 4.49±0.02ms         | 1.00    | experimental.ugrid.MeshCoord.time_create(1000000)                                                    |
|          | 244±1μs              | 244±2μs             | 1.00    | experimental.ugrid.MeshCoord.time_create(6)                                                          |
|          | 4.91±0.08μs          | 4.88±0.04μs         | 0.99    | experimental.ugrid.MeshCoord.time_points(10000)                                                      |
|          | 6.41±0.07μs          | 6.35±0.04μs         | 0.99    | experimental.ugrid.MeshCoord.time_points(1000000)                                                    |
|          | 3.73±0.05μs          | 3.71±0.05μs         | 1.00    | experimental.ugrid.MeshCoord.time_points(6)                                                          |
|          | 9.61±0.2ms           | 9.64±0.2ms          | 1.00    | experimental.ugrid.MeshCoordLazy.time_bounds(10000)                                                  |
|          | 262±2ms              | 260±2ms             | 0.99    | experimental.ugrid.MeshCoordLazy.time_bounds(1000000)                                                |
|          | 14.6±0.8μs           | 14.1±0.7μs          | 0.97    | experimental.ugrid.MeshCoordLazy.time_bounds(6)                                                      |
|          | 4.45±0.04ms          | 4.49±0.03ms         | 1.01    | experimental.ugrid.MeshCoordLazy.time_create(10000)                                                  |
|          | 4.54±0.03ms          | 4.57±0.05ms         | 1.01    | experimental.ugrid.MeshCoordLazy.time_create(1000000)                                                |
|          | 293±10μs             | 294±10μs            | 1.00    | experimental.ugrid.MeshCoordLazy.time_create(6)                                                      |
|          | 3.45±0.06ms          | 3.48±0.08ms         | 1.01    | experimental.ugrid.MeshCoordLazy.time_points(10000)                                                  |
|          | 7.99±0.1ms           | 7.97±0.1ms          | 1.00    | experimental.ugrid.MeshCoordLazy.time_points(1000000)                                                |
|          | 9.75±0.7μs           | 9.35±0.7μs          | 0.96    | experimental.ugrid.MeshCoordLazy.time_points(6)                                                      |
|          | 44.6±3μs             | 45.1±2μs            | 1.01    | experimental.ugrid.MeshLazy.time_add_connectivities(1000000)                                         |
|          | 377±7μs              | 378±5μs             | 1.00    | experimental.ugrid.MeshLazy.time_add_connectivities(6)                                               |
|          | 26.9±1μs             | 26.7±1μs            | 0.99    | experimental.ugrid.MeshLazy.time_add_coords(1000000)                                                 |
|          | 21.1±1μs             | 22.1±2μs            | 1.05    | experimental.ugrid.MeshLazy.time_add_coords(6)                                                       |
|          | 25.1±2μs             | 24.8±1μs            | 0.99    | experimental.ugrid.MeshLazy.time_connectivities(1000000)                                             |
|          | 21.9±0.9μs           | 22.4±0.9μs          | 1.02    | experimental.ugrid.MeshLazy.time_connectivities(6)                                                   |
|          | 28.6±2μs             | 29.3±2μs            | 1.03    | experimental.ugrid.MeshLazy.time_coords(1000000)                                                     |
|          | 26.2±1μs             | 25.5±0.9μs          | 0.98    | experimental.ugrid.MeshLazy.time_coords(6)                                                           |
|          | 113±7μs              | 112±7μs             | 0.99    | experimental.ugrid.MeshLazy.time_create(1000000)                                                     |
|          | 440±10μs             | 443±10μs            | 1.01    | experimental.ugrid.MeshLazy.time_create(6)                                                           |
|          | 126±3ms              | 125±3ms             | 0.99    | experimental.ugrid.MeshLazy.time_eq(1000000)                                                         |
|          | 430±10μs             | 429±10μs            | 1.00    | experimental.ugrid.MeshLazy.time_eq(6)                                                               |
|          | 27.0±1μs             | 27.2±1μs            | 1.01    | experimental.ugrid.MeshLazy.time_remove_connectivities(1000000)                                      |
|          | 23.7±1μs             | 23.2±1μs            | 0.98    | experimental.ugrid.MeshLazy.time_remove_connectivities(6)                                            |
|          | 46.0±3μs             | 46.3±3μs            | 1.01    | experimental.ugrid.MeshLazy.time_remove_coords(1000000)                                              |
|          | 40.5±2μs             | 40.3±1μs            | 0.99    | experimental.ugrid.MeshLazy.time_remove_coords(6)                                                    |
|          | n/a                  | n/a                 | n/a     | experimental.ugrid.UGridCommon.time_create(1000000)                                                  |
|          | n/a                  | n/a                 | n/a     | experimental.ugrid.UGridCommon.time_create(6)                                                        |
|          | 666±10ns             | 668±3ns             | 1.00    | experimental.ugrid.regions_combine.CombineRegionsComputeRealData.time_compute_data(50)               |
|          | 384±3ms              | 384±3ms             | 1.00    | experimental.ugrid.regions_combine.CombineRegionsComputeRealData.time_compute_data(500)              |
|          | 15.4±0.05ms          | 15.5±0.06ms         | 1.01    | experimental.ugrid.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50)            |
|          | 19.8±0.2ms           | 20.1±0.2ms          | 1.01    | experimental.ugrid.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(500)           |
|          | 5.0                  | 5.0                 | 1.00    | experimental.ugrid.regions_combine.CombineRegionsCreateCube.track_addedmem_create_combined_cube(50)  |
|          | 5.0                  | 5.0                 | 1.00    | experimental.ugrid.regions_combine.CombineRegionsCreateCube.track_addedmem_create_combined_cube(500) |
|          | 187±1ms              | 186±2ms             | 0.99    | experimental.ugrid.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(50)          |
|          | 961±6ms              | 965±8ms             | 1.00    | experimental.ugrid.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(500)         |
|          | 130±1ms              | 131±1ms             | 1.01    | experimental.ugrid.regions_combine.CombineRegionsSaveData.time_save(50)                              |
|          | 892±5ms              | 895±10ms            | 1.00    | experimental.ugrid.regions_combine.CombineRegionsSaveData.time_save(500)                             |
|          | 2.1752849999999997   | 2.1752849999999997  | 1.00    | experimental.ugrid.regions_combine.CombineRegionsSaveData.track_filesize_saved(50)                   |
|          | 216.01528499999998   | 216.01528499999998  | 1.00    | experimental.ugrid.regions_combine.CombineRegionsSaveData.track_filesize_saved(500)                  |
|          | 836±7μs              | 833±2μs             | 1.00    | import_iris.Iris.time__concatenate                                                                   |
|          | 228±2μs              | 227±2μs             | 0.99    | import_iris.Iris.time__constraints                                                                   |
|          | 115±0.7μs            | 116±1μs             | 1.01    | import_iris.Iris.time__data_manager                                                                  |
|          | 95.3±0.3μs           | 95.9±0.2μs          | 1.01    | import_iris.Iris.time__deprecation                                                                   |
|          | 124±1μs              | 123±3μs             | 0.99    | import_iris.Iris.time__lazy_data                                                                     |
|          | 1.15±0.01ms          | 1.14±0.01ms         | 1.00    | import_iris.Iris.time__merge                                                                         |
|          | 74.6±0.2μs           | 75.2±0.3μs          | 1.01    | import_iris.Iris.time__representation                                                                |
|          | 677±8μs              | 663±5μs             | 0.98    | import_iris.Iris.time_analysis                                                                       |
|          | 181±3μs              | 173±2μs             | 0.96    | import_iris.Iris.time_analysis__area_weighted                                                        |
|          | 111±2μs              | 113±1μs             | 1.01    | import_iris.Iris.time_analysis__grid_angles                                                          |
|          | 313±2μs              | 314±3μs             | 1.00    | import_iris.Iris.time_analysis__interpolation                                                        |
|          | 240±1μs              | 240±2μs             | 1.00    | import_iris.Iris.time_analysis__regrid                                                               |
|          | 115±0.3μs            | 116±0.4μs           | 1.01    | import_iris.Iris.time_analysis__scipy_interpolate                                                    |
|          | 161±2μs              | 162±2μs             | 1.01    | import_iris.Iris.time_analysis_calculus                                                              |
|          | 425±3μs              | 427±3μs             | 1.01    | import_iris.Iris.time_analysis_cartography                                                           |
|          | 90.4±0.3μs           | 91.9±2μs            | 1.02    | import_iris.Iris.time_analysis_geomerty                                                              |
|          | 286±2μs              | 286±2μs             | 1.00    | import_iris.Iris.time_analysis_maths                                                                 |
|          | 88.0±0.4μs           | 90.0±0.5μs          | 1.02    | import_iris.Iris.time_analysis_stats                                                                 |
|          | 232±2μs              | 231±3μs             | 0.99    | import_iris.Iris.time_analysis_trajectory                                                            |
|          | 396±2μs              | 397±3μs             | 1.00    | import_iris.Iris.time_aux_factory                                                                    |
|          | 83.6±0.3μs           | 84.5±0.4μs          | 1.01    | import_iris.Iris.time_common                                                                         |
|          | 204±3μs              | 205±2μs             | 1.00    | import_iris.Iris.time_common_lenient                                                                 |
|          | 1.23±0.01ms          | 1.23±0.01ms         | 0.99    | import_iris.Iris.time_common_metadata                                                                |
|          | 156±0.5μs            | 156±1μs             | 1.00    | import_iris.Iris.time_common_mixin                                                                   |
|          | 1.42±0.01ms          | 1.42±0ms            | 1.00    | import_iris.Iris.time_common_resolve                                                                 |
|          | 245±2μs              | 246±0.9μs           | 1.00    | import_iris.Iris.time_config                                                                         |
|          | 125±2μs              | 124±1μs             | 1.00    | import_iris.Iris.time_coord_categorisation                                                           |
|          | 438±7μs              | 436±3μs             | 1.00    | import_iris.Iris.time_coord_systems                                                                  |
|          | 921±10μs             | 911±5μs             | 0.99    | import_iris.Iris.time_coords                                                                         |
|          | 767±8μs              | 765±10μs            | 1.00    | import_iris.Iris.time_cube                                                                           |
|          | 685±5μs              | 677±5μs             | 0.99    | import_iris.Iris.time_exceptions                                                                     |
|          | 75.2±0.3μs           | 75.9±0.5μs          | 1.01    | import_iris.Iris.time_experimental                                                                   |
|          | 249±1μs              | 249±0.4μs           | 1.00    | import_iris.Iris.time_fileformats                                                                    |
|          | 335±4μs              | 330±2μs             | 0.99    | import_iris.Iris.time_fileformats__ff                                                                |
|          | 3.57±0.02ms          | 3.57±0.01ms         | 1.00    | import_iris.Iris.time_fileformats__ff_cross_references                                               |
|          | 79.3±0.7μs           | 79.8±0.7μs          | 1.01    | import_iris.Iris.time_fileformats__pp_lbproc_pairs                                                   |
|          | 121±0.7μs            | 121±2μs             | 1.00    | import_iris.Iris.time_fileformats_abf                                                                |
|          | 480±2μs              | 481±6μs             | 1.00    | import_iris.Iris.time_fileformats_cf                                                                 |
|          | 6.22±0.03ms          | 6.21±0.05ms         | 1.00    | import_iris.Iris.time_fileformats_dot                                                                |
|          | 73.6±0.5μs           | 73.5±0.2μs          | 1.00    | import_iris.Iris.time_fileformats_name                                                               |
|          | 350±1μs              | 352±3μs             | 1.00    | import_iris.Iris.time_fileformats_name_loaders                                                       |
|          | 124±2μs              | 123±1μs             | 0.99    | import_iris.Iris.time_fileformats_netcdf                                                             |
|          | 136±0.5μs            | 136±0.7μs           | 1.01    | import_iris.Iris.time_fileformats_nimrod                                                             |
|          | 270±1μs              | 271±2μs             | 1.00    | import_iris.Iris.time_fileformats_nimrod_load_rules                                                  |
|          | 984±4μs              | 979±6μs             | 1.00    | import_iris.Iris.time_fileformats_pp                                                                 |
|          | 219±1μs              | 219±2μs             | 1.00    | import_iris.Iris.time_fileformats_pp_load_rules                                                      |
|          | 150±2μs              | 150±0.8μs           | 1.00    | import_iris.Iris.time_fileformats_pp_save_rules                                                      |
|          | 627±3μs              | 626±3μs             | 1.00    | import_iris.Iris.time_fileformats_rules                                                              |
|          | 272±2μs              | 272±1μs             | 1.00    | import_iris.Iris.time_fileformats_structured_array_identification                                    |
|          | 82.6±0.4μs           | 82.3±0.7μs          | 1.00    | import_iris.Iris.time_fileformats_um                                                                 |
|          | 202±2μs              | 207±3μs             | 1.03    | import_iris.Iris.time_fileformats_um__fast_load                                                      |
|          | 170±1μs              | 168±2μs             | 0.98    | import_iris.Iris.time_fileformats_um__fast_load_structured_fields                                    |
|          | 75.7±0.6μs           | 75.6±0.2μs          | 1.00    | import_iris.Iris.time_fileformats_um__ff_replacement                                                 |
|          | 84.0±0.5μs           | 84.4±0.4μs          | 1.01    | import_iris.Iris.time_fileformats_um__optimal_array_structuring                                      |
|          | 1.31±0ms             | 1.31±0ms            | 1.00    | import_iris.Iris.time_fileformats_um_cf_map                                                          |
|          | 156±0.9μs            | 156±2μs             | 1.00    | import_iris.Iris.time_io                                                                             |
|          | 227±3μs              | 225±2μs             | 0.99    | import_iris.Iris.time_io_format_picker                                                               |
|          | 254±0.9μs            | 256±0.7μs           | 1.01    | import_iris.Iris.time_iris                                                                           |
|          | 150±1μs              | 150±1μs             | 1.00    | import_iris.Iris.time_iterate                                                                        |
|          | 10.3±0.05ms          | 10.4±0.03ms         | 1.01    | import_iris.Iris.time_palette                                                                        |
|          | 466±2μs              | 466±3μs             | 1.00    | import_iris.Iris.time_plot                                                                           |
|          | 111±0.4μs            | 111±1μs             | 1.00    | import_iris.Iris.time_quickplot                                                                      |
|          | 2.79±0.01ms          | 2.78±0.01ms         | 1.00    | import_iris.Iris.time_std_names                                                                      |
|          | 2.17±0.04ms          | 2.17±0.01ms         | 1.00    | import_iris.Iris.time_symbols                                                                        |
|          | 186±20ms             | 175±10ms            | 0.94    | import_iris.Iris.time_tests                                                                          |
|          | 283±1μs              | 287±1μs             | 1.01    | import_iris.Iris.time_third_party_cartopy                                                            |
|          | 6.10±0.04ms          | 6.06±0.05ms         | 0.99    | import_iris.Iris.time_third_party_cf_units                                                           |
|          | 117±0.5μs            | 118±0.6μs           | 1.01    | import_iris.Iris.time_third_party_cftime                                                             |
|          | 3.56±0.01ms          | 3.56±0.01ms         | 1.00    | import_iris.Iris.time_third_party_matplotlib                                                         |
|          | 1.49±0.01ms          | 1.49±0.01ms         | 1.00    | import_iris.Iris.time_third_party_numpy                                                              |
|          | 2.60±0.02ms          | 2.60±0.02ms         | 1.00    | import_iris.Iris.time_third_party_scipy                                                              |
|          | 101±2μs              | 102±1μs             | 1.01    | import_iris.Iris.time_time                                                                           |
|          | 420±2μs              | 419±3μs             | 1.00    | import_iris.Iris.time_util                                                                           |
|          | 95.1±0.5μs           | 95.7±0.6μs          | 1.01    | iterate.IZip.time_izip                                                                               |
|          | 9.08±0.03ms          | 9.06±0.02ms         | 1.00    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'FF')                                           |
|          | 30.4±0.6ms           | 29.9±0.4ms          | 0.98    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'NetCDF')                                       |
|          | 9.87±0.02ms          | 9.89±0.04ms         | 1.00    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'PP')                                           |
|          | 9.04±0.02ms          | 9.06±0.03ms         | 1.00    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'FF')                                            |
|          | 25.9±0.2ms           | 25.8±0.1ms          | 1.00    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'NetCDF')                                        |
|          | 9.89±0.03ms          | 9.90±0.04ms         | 1.00    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'PP')                                            |
|          | 1.53±0s              | 1.54±0s             | 1.01    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'FF')                                             |
|          | 24.6±0.2ms           | 24.6±0.3ms          | 1.00    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'NetCDF')                                         |
|          | 1.70±0.01s           | 1.70±0s             | 1.00    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'PP')                                             |
|          | 1.53±0s              | 1.54±0s             | 1.00    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'FF')                                              |
|          | 24.8±0.2ms           | 24.6±0.2ms          | 0.99    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'NetCDF')                                          |
|          | 1.70±0.01s           | 1.70±0s             | 1.00    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'PP')                                              |
|          | 4.37±0.01ms          | 4.38±0.01ms         | 1.00    | load.LoadAndRealise.time_load((50, 50, 2), False, 'FF')                                              |
|          | 24.0±0.2ms           | 24.0±0.1ms          | 1.00    | load.LoadAndRealise.time_load((50, 50, 2), False, 'NetCDF')                                          |
|          | 4.65±0.02ms          | 4.66±0.02ms         | 1.00    | load.LoadAndRealise.time_load((50, 50, 2), False, 'PP')                                              |
|          | 4.37±0.01ms          | 4.37±0.01ms         | 1.00    | load.LoadAndRealise.time_load((50, 50, 2), True, 'FF')                                               |
|          | 24.0±0.2ms           | 24.1±0.2ms          | 1.00    | load.LoadAndRealise.time_load((50, 50, 2), True, 'NetCDF')                                           |
|          | 4.65±0.01ms          | 4.65±0.02ms         | 1.00    | load.LoadAndRealise.time_load((50, 50, 2), True, 'PP')                                               |
|          | 47.7±0.9ms           | 47.2±0.7ms          | 0.99    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'FF')                                        |
|          | 35.8±0.7ms           | 35.7±0.8ms          | 1.00    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'NetCDF')                                    |
|          | 17.1±1ms             | 18.3±2ms            | 1.07    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'PP')                                        |
|          | 42.4±0.4ms           | 41.9±1ms            | 0.99    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'FF')                                         |
|          | 89.9±0.4ms           | 89.6±0.6ms          | 1.00    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'NetCDF')                                     |
|          | 42.3±1ms             | 42.3±0.8ms          | 1.00    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'PP')                                         |
|          | 439±4ms              | 438±3ms             | 1.00    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'FF')                                          |
|          | 4.20±0.1ms           | 4.13±0.09ms         | 0.98    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'NetCDF')                                      |
|          | 445±3ms              | 443±4ms             | 0.99    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'PP')                                          |
|          | 449±4ms              | 447±2ms             | 1.00    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'FF')                                           |
|          | 4.29±0.1ms           | 4.31±0.1ms          | 1.00    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'NetCDF')                                       |
|          | 457±2ms              | 458±4ms             | 1.00    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'PP')                                           |
|          | 1.67±0.1ms           | 1.65±0.1ms          | 0.99    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'FF')                                           |
|          | 4.41±0.2ms           | 4.06±0.1ms          | 0.92    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'NetCDF')                                       |
|          | 1.64±0.1ms           | 1.68±0.1ms          | 1.02    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'PP')                                           |
|          | 1.64±0.09ms          | 1.64±0.09ms         | 1.00    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'FF')                                            |
|          | 4.30±0.1ms           | 4.26±0.07ms         | 0.99    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'NetCDF')                                        |
|          | 1.69±0.1ms           | 1.66±0.08ms         | 0.98    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'PP')                                            |
|          | 428±2ms              | 425±3ms             | 0.99    | load.ManyVars.time_many_var_load                                                                     |
|          | 9.21±0.03ms          | 9.23±0.03ms         | 1.00    | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'FF')                                     |
|          | 10.1±0.06ms          | 10.1±0.03ms         | 1.00    | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'PP')                                     |
|          | 1.56±0s              | 1.56±0s             | 1.01    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'FF')                                       |
|          | 1.73±0.01s           | 1.73±0s             | 1.00    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'PP')                                       |
|          | 4.38±0.02ms          | 4.40±0.02ms         | 1.00    | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'FF')                                          |
|          | 4.71±0.02ms          | 4.70±0.02ms         | 1.00    | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'PP')                                          |
|          | 9.09±0.02ms          | 9.09±0.01ms         | 1.00    | load.StructuredFF.time_structured_load((1280, 960, 5), False)                                        |
|          | 5.10±0.01ms          | 5.08±0.02ms         | 1.00    | load.StructuredFF.time_structured_load((1280, 960, 5), True)                                         |
|          | 1.53±0s              | 1.54±0s             | 1.01    | load.StructuredFF.time_structured_load((2, 2, 1000), False)                                          |
|          | 373±1ms              | 374±3ms             | 1.00    | load.StructuredFF.time_structured_load((2, 2, 1000), True)                                           |
|          | 4.35±0.02ms          | 4.35±0.02ms         | 1.00    | load.StructuredFF.time_structured_load((2, 2, 2), False)                                             |
|          | 3.94±0.01ms          | 3.93±0.02ms         | 1.00    | load.StructuredFF.time_structured_load((2, 2, 2), True)                                              |
|          | 177±0.9ms            | 176±0.9ms           | 1.00    | load.TimeConstraint.time_time_constraint(20, 'FF')                                                   |
|          | 28.6±0.3ms           | 28.2±0.5ms          | 0.99    | load.TimeConstraint.time_time_constraint(20, 'NetCDF')                                               |
|          | 193±0.3ms            | 193±0.6ms           | 1.00    | load.TimeConstraint.time_time_constraint(20, 'PP')                                                   |
|          | 34.2±0.2ms           | 34.2±0.2ms          | 1.00    | load.TimeConstraint.time_time_constraint(3, 'FF')                                                    |
|          | 28.0±0.3ms           | 28.0±0.3ms          | 1.00    | load.TimeConstraint.time_time_constraint(3, 'NetCDF')                                                |
|          | 36.3±0.1ms           | 36.6±0.3ms          | 1.01    | load.TimeConstraint.time_time_constraint(3, 'PP')                                                    |
|          | 21.4±0.3ms           | 21.5±0.3ms          | 1.01    | load.ugrid.BasicLoading.time_load_file(1)                                                            |
|          | 50.0±0.9ms           | 50.3±0.5ms          | 1.01    | load.ugrid.BasicLoading.time_load_file(200000)                                                       |
|          | 17.3±0.6ms           | 17.6±0.5ms          | 1.01    | load.ugrid.BasicLoading.time_load_mesh(1)                                                            |
|          | 28.9±1ms             | 29.6±0.4ms          | 1.02    | load.ugrid.BasicLoading.time_load_mesh(200000)                                                       |
|          | 21.4±0.4ms           | 21.7±0.5ms          | 1.01    | load.ugrid.BasicLoadingTime.time_load_file(1)                                                        |
|          | 25.4±0.4ms           | 26.2±0.6ms          | 1.03    | load.ugrid.BasicLoadingTime.time_load_file(200000)                                                   |
|          | 17.1±0.3ms           | 17.6±0.3ms          | 1.03    | load.ugrid.BasicLoadingTime.time_load_mesh(1)                                                        |
|          | 21.1±0.5ms           | 21.5±0.8ms          | 1.02    | load.ugrid.BasicLoadingTime.time_load_mesh(200000)                                                   |
|          | 22.7±0.4ms           | 22.9±0.6ms          | 1.01    | load.ugrid.Callback.time_load_file_callback(1)                                                       |
|          | 60.0±1ms             | 60.4±0.9ms          | 1.01    | load.ugrid.Callback.time_load_file_callback(200000)                                                  |
|          | 22.7±0.4ms           | 22.9±0.6ms          | 1.01    | load.ugrid.CallbackTime.time_load_file_callback(1)                                                   |
|          | 27.2±0.6ms           | 27.2±0.9ms          | 1.00    | load.ugrid.CallbackTime.time_load_file_callback(200000)                                              |
|          | 4.00±0.1ms           | 4.00±0.2ms          | 1.00    | load.ugrid.DataRealisation.time_realise_data(10000)                                                  |
|          | 8.76±0.2ms           | 8.88±0.2ms          | 1.01    | load.ugrid.DataRealisation.time_realise_data(200000)                                                 |
|          | 60.9±1ms             | 60.8±2ms            | 1.00    | load.ugrid.DataRealisationTime.time_realise_data(10000)                                              |
|          | 1.15±0.01s           | 1.15±0s             | 1.00    | load.ugrid.DataRealisationTime.time_realise_data(200000)                                             |
|          | 131±0.5ns            | 133±1ns             | 1.02    | metadata_manager_factory.MetadataManagerFactory.time_AncillaryVariableMetadata_fields                |
|          | 1.19±0.01μs          | 1.17±0.01μs         | 0.99    | metadata_manager_factory.MetadataManagerFactory.time_AncillaryVariableMetadata_values                |
|          | 131±0.6ns            | 133±0.5ns           | 1.01    | metadata_manager_factory.MetadataManagerFactory.time_BaseMetadata_fields                             |
|          | 1.18±0μs             | 1.16±0.01μs         | 0.99    | metadata_manager_factory.MetadataManagerFactory.time_BaseMetadata_values                             |
|          | 132±0.4ns            | 137±3ns             | 1.04    | metadata_manager_factory.MetadataManagerFactory.time_CellMeasuresMetadata_fields                     |
|          | 1.33±0.01μs          | 1.33±0.02μs         | 1.00    | metadata_manager_factory.MetadataManagerFactory.time_CellMeasuresMetadata_values                     |
|          | 132±1ns              | 133±0.4ns           | 1.01    | metadata_manager_factory.MetadataManagerFactory.time_CoordMetadata_fields                            |
|          | 1.42±0.01μs          | 1.42±0.01μs         | 1.00    | metadata_manager_factory.MetadataManagerFactory.time_CoordMetadata_values                            |
|          | 132±0.6ns            | 133±0.5ns           | 1.01    | metadata_manager_factory.MetadataManagerFactory.time_CubeMetadata_fields                             |
|          | 1.32±0.01μs          | 1.34±0.01μs         | 1.01    | metadata_manager_factory.MetadataManagerFactory.time_CubeMetadata_values                             |
|          | 132±0.4ns            | 134±0.1ns           | 1.01    | metadata_manager_factory.MetadataManagerFactory.time_DimCoordMetadata_fields                         |
|          | 1.51±0μs             | 1.52±0.01μs         | 1.01    | metadata_manager_factory.MetadataManagerFactory.time_DimCoordMetadata_values                         |
|          | 1.26±0.01μs          | 1.25±0.01μs         | 0.99    | metadata_manager_factory.MetadataManagerFactory__create.time_AncillaryVariableMetadata(1)            |
|          | 9.05±0.09μs          | 8.95±0.1μs          | 0.99    | metadata_manager_factory.MetadataManagerFactory__create.time_AncillaryVariableMetadata(10)           |
|          | 84.3±0.9μs           | 84.5±0.2μs          | 1.00    | metadata_manager_factory.MetadataManagerFactory__create.time_AncillaryVariableMetadata(100)          |
|          | 1.28±0.01μs          | 1.26±0.01μs         | 0.99    | metadata_manager_factory.MetadataManagerFactory__create.time_BaseMetadata(1)                         |
|          | 9.05±0.08μs          | 8.97±0.04μs         | 0.99    | metadata_manager_factory.MetadataManagerFactory__create.time_BaseMetadata(10)                        |
|          | 84.6±1μs             | 84.6±0.2μs          | 1.00    | metadata_manager_factory.MetadataManagerFactory__create.time_BaseMetadata(100)                       |
|          | 1.33±0.04μs          | 1.32±0.01μs         | 0.99    | metadata_manager_factory.MetadataManagerFactory__create.time_CellMeasureMetadata(1)                  |
|          | 9.60±0.08μs          | 9.61±0.09μs         | 1.00    | metadata_manager_factory.MetadataManagerFactory__create.time_CellMeasureMetadata(10)                 |
|          | 91.9±2μs             | 91.1±0.7μs          | 0.99    | metadata_manager_factory.MetadataManagerFactory__create.time_CellMeasureMetadata(100)                |
|          | 1.39±0.03μs          | 1.37±0.01μs         | 0.99    | metadata_manager_factory.MetadataManagerFactory__create.time_CoordMetadata(1)                        |
|          | 10.2±0.2μs           | 10.1±0.06μs         | 0.99    | metadata_manager_factory.MetadataManagerFactory__create.time_CoordMetadata(10)                       |
|          | 96.7±2μs             | 95.5±0.7μs          | 0.99    | metadata_manager_factory.MetadataManagerFactory__create.time_CoordMetadata(100)                      |
|          | 1.34±0.03μs          | 1.32±0.01μs         | 0.99    | metadata_manager_factory.MetadataManagerFactory__create.time_CubeMetadata(1)                         |
|          | 9.71±0.3μs           | 9.71±0.06μs         | 1.00    | metadata_manager_factory.MetadataManagerFactory__create.time_CubeMetadata(10)                        |
|          | 92.3±2μs             | 91.3±0.3μs          | 0.99    | metadata_manager_factory.MetadataManagerFactory__create.time_CubeMetadata(100)                       |
|          | 1.45±0.02μs          | 1.43±0.01μs         | 0.99    | metadata_manager_factory.MetadataManagerFactory__create.time_DimCoordMetadata(1)                     |
|          | 10.7±0.2μs           | 10.7±0.2μs          | 0.99    | metadata_manager_factory.MetadataManagerFactory__create.time_DimCoordMetadata(10)                    |
|          | 101±0.5μs            | 101±0.7μs           | 1.00    | metadata_manager_factory.MetadataManagerFactory__create.time_DimCoordMetadata(100)                   |
|          | 135±1ns              | 136±1ns             | 1.00    | mixin.CFVariableMixin.time_get_attributes                                                            |
|          | 137±1ns              | 136±1ns             | 1.00    | mixin.CFVariableMixin.time_get_long_name                                                             |
|          | 1.31±0.01μs          | 1.31±0.03μs         | 1.00    | mixin.CFVariableMixin.time_get_metadata                                                              |
|          | 136±0.6ns            | 136±0.6ns           | 1.00    | mixin.CFVariableMixin.time_get_standard_name                                                         |
|          | 136±1ns              | 137±1ns             | 1.00    | mixin.CFVariableMixin.time_get_units                                                                 |
|          | 135±0.7ns            | 136±3ns             | 1.01    | mixin.CFVariableMixin.time_get_var_name                                                              |
|          | 930±10ns             | 924±4ns             | 0.99    | mixin.CFVariableMixin.time_set_attributes                                                            |
|          | 154±0.7ns            | 154±0.6ns           | 1.00    | mixin.CFVariableMixin.time_set_long_name                                                             |
|          | 4.69±0.04μs          | 4.66±0.03μs         | 0.99    | mixin.CFVariableMixin.time_set_metadata__dict                                                        |
|          | 5.92±0.09μs          | 5.93±0.03μs         | 1.00    | mixin.CFVariableMixin.time_set_metadata__metadata                                                    |
|          | 5.85±0.05μs          | 5.85±0.05μs         | 1.00    | mixin.CFVariableMixin.time_set_metadata__tuple                                                       |
|          | 835±2ns              | 837±9ns             | 1.00    | mixin.CFVariableMixin.time_set_standard_name                                                         |
|          | 537±3ns              | 543±2ns             | 1.01    | mixin.CFVariableMixin.time_set_units                                                                 |
|          | 572±3ns              | 567±20ns            | 0.99    | mixin.CFVariableMixin.time_set_var_name                                                              |
|          | 600±3ms              | 603±5ms             | 1.01    | plot.AuxSort.time_aux_sort                                                                           |
|          | 153±1ms              | 153±3ms             | 1.00    | regridding.CurvilinearRegridding.time_regrid_pic                                                     |
|          | 4.63±0.05ms          | 4.71±0.05ms         | 1.02    | save.NetcdfSave.time_netcdf_save_cube(50, False)                                                     |
|          | 129±1ms              | 129±4ms             | 1.00    | save.NetcdfSave.time_netcdf_save_cube(50, True)                                                      |
|          | 50.3±20ms            | 50.7±20ms           | 1.01    | save.NetcdfSave.time_netcdf_save_cube(600, False)                                                    |
|          | 689±3ms              | 696±9ms             | 1.01    | save.NetcdfSave.time_netcdf_save_cube(600, True)                                                     |
|          | 115±0.5ns            | 115±0.3ns           | 1.00    | save.NetcdfSave.time_netcdf_save_mesh(50, False)                                                     |
|          | 93.8±1ms             | 98.8±3ms            | 1.05    | save.NetcdfSave.time_netcdf_save_mesh(50, True)                                                      |
|          | 115±0.3ns            | 115±0.4ns           | 1.00    | save.NetcdfSave.time_netcdf_save_mesh(600, False)                                                    |
|          | 585±7ms              | 586±8ms             | 1.00    | save.NetcdfSave.time_netcdf_save_mesh(600, True)                                                     |
|          | 36.9±1ms             | 37.0±1ms            | 1.00    | trajectory.TrajectoryInterpolation.time_trajectory_linear                                            |
|          | 89.5±0.9ms           | 89.7±0.9ms          | 1.00    | trajectory.TrajectoryInterpolation.time_trajectory_nearest                                           |

Generated by GHA run 6576861444

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0b569cd) 89.41% compared to head (7515c50) 89.55%.
Report is 22 commits behind head on main.

Files Patch % Lines
lib/iris/analysis/_area_weighted.py 97.70% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5543      +/-   ##
==========================================
+ Coverage   89.41%   89.55%   +0.13%     
==========================================
  Files          89       89              
  Lines       22539    22495      -44     
  Branches     5387     5351      -36     
==========================================
- Hits        20154    20146       -8     
+ Misses       1639     1616      -23     
+ Partials      746      733      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trexfeathers trexfeathers linked an issue Nov 2, 2023 that may be closed by this pull request
@stephenworsley
Copy link
Contributor Author

Note: this PR builds a wights matrix and performs regridding with the expectation that the standard cube has the last two dimensions as the y and x dimension (see the change made in this commit 90130cc). This decision is made in order to maintain consistency with patterns established in existing regridders, e.g. the ordering of dims expected in this line for example:

result = np.moveaxis(result, [-2, -1], dims)

This cosistency is important so that further unification of regridding can take place without having to change the expected ordering of weights matrices associated with regridders.

This decision is also in keeping with recomendations in CF conventions, see http://cfconventions.org/Data/cf-conventions/cf-conventions-1.10/cf-conventions.html#dimensions

@stephenworsley stephenworsley marked this pull request as ready for review November 8, 2023 16:54
Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic performance benefits, great work. Just a few minor changes.

lib/iris/analysis/_area_weighted.py Outdated Show resolved Hide resolved
lib/iris/analysis/_area_weighted.py Show resolved Hide resolved
lib/iris/analysis/_area_weighted.py Show resolved Hide resolved
lib/iris/analysis/_area_weighted.py Outdated Show resolved Hide resolved
lib/iris/analysis/_area_weighted.py Outdated Show resolved Hide resolved
Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @stephenworsley, merging this and we will add a whatsnew entry in a seperate PR

@HGWright HGWright merged commit 20393cc into SciTools:main Nov 20, 2023
17 checks passed
tkknight added a commit to tkknight/iris that referenced this pull request Nov 27, 2023
* upstream/main:
  Mergeback of `FEATURE_chunk_control` branch (SciTools#5588)
  [CI Bot] environment lockfiles auto-update (SciTools#5547)
  Mergeback of "Feature _split_attrs" branch (SciTools#5152)
  add whatsnew (SciTools#5596)
  Refactor area weighted regridding, improve performance (SciTools#5543)
  Allowing exemption to axis guessing on coords (SciTools#5551)
tkknight added a commit to tkknight/iris that referenced this pull request Dec 6, 2023
* main:
  DOCS: Numpydocs1 (SciTools#5578)
  add links to scitools-classroom repo. (SciTools#5609)
  Feedstock rc branch management in do-nothing script (SciTools#5515)
  Relocated the Technical Papers documentation to Further Topics.  (SciTools#5602)
  Fix pp save of realization coordinate (SciTools#5568)
  Bump actions/checkout from 3 to 4 (SciTools#5460)
  Bump actions/github-script from 6 to 7 (SciTools#5580)
  Bump conda-incubator/setup-miniconda from 2 to 3 (SciTools#5607)
  CI: specify matplotlib-base (SciTools#5606)
  Mergeback of `FEATURE_chunk_control` branch (SciTools#5588)
  [CI Bot] environment lockfiles auto-update (SciTools#5547)
  Mergeback of "Feature _split_attrs" branch (SciTools#5152)
  add whatsnew (SciTools#5596)
  Refactor area weighted regridding, improve performance (SciTools#5543)
  Allowing exemption to axis guessing on coords (SciTools#5551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance improvements to AreaWeighted with sparse matrices
2 participants